This repository was archived by the owner on Nov 4, 2022. It is now read-only.
Fixed some issues I found during dry-run #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In my testing it doesn't happen on AL2 Cloud9 on SAM CLI version 1.16.0
Otherwise it is only pushed as part of the next lab section
thomasfr approved these changes Feb 17, 2021
thomasfr left a comment
thomasfr left a comment There was a problem hiding this comment.
went through the workshop following the guide applying those changes. Can approve that those changes worked for me and made sense.
Contributor
| Thanks for the contribution! Will merge shortly |
ferdingler approved these changes Feb 18, 2021
Contributor
| Merged, created a new release https://github.com/aws-samples/aws-serverless-cicd-workshop/releases/tag/v3.0.8 . Your changes should already be live on the main website: https://cicd.serverlessworkshops.io |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Running this next Monday; mostly minor updates; let me know if you have questions or need separate PRs.