Skip to content

Commit 0b781f5

Browse files
committed
clocksource/drivers/vf-pit: Replace raw_readl/writel to readl/writel
The driver uses the raw_readl() and raw_writel() functions. Those are not for MMIO devices. Replace them with readl() and writel() [ dlezcano: Fixed typo in the subject s/reald/readl/ ] Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Acked-by: Arnd Bergmann <arnd@arndb.de> Cc: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20250804152344.1109310-2-daniel.lezcano@linaro.org
1 parent 99d1971 commit 0b781f5

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

drivers/clocksource/timer-vf-pit.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,30 +35,30 @@ static unsigned long cycle_per_jiffy;
3535

3636
static inline void pit_timer_enable(void)
3737
{
38-
__raw_writel(PITTCTRL_TEN | PITTCTRL_TIE, clkevt_base + PITTCTRL);
38+
writel(PITTCTRL_TEN | PITTCTRL_TIE, clkevt_base + PITTCTRL);
3939
}
4040

4141
static inline void pit_timer_disable(void)
4242
{
43-
__raw_writel(0, clkevt_base + PITTCTRL);
43+
writel(0, clkevt_base + PITTCTRL);
4444
}
4545

4646
static inline void pit_irq_acknowledge(void)
4747
{
48-
__raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
48+
writel(PITTFLG_TIF, clkevt_base + PITTFLG);
4949
}
5050

5151
static u64 notrace pit_read_sched_clock(void)
5252
{
53-
return ~__raw_readl(clksrc_base + PITCVAL);
53+
return ~readl(clksrc_base + PITCVAL);
5454
}
5555

5656
static int __init pit_clocksource_init(unsigned long rate)
5757
{
5858
/* set the max load value and start the clock source counter */
59-
__raw_writel(0, clksrc_base + PITTCTRL);
60-
__raw_writel(~0UL, clksrc_base + PITLDVAL);
61-
__raw_writel(PITTCTRL_TEN, clksrc_base + PITTCTRL);
59+
writel(0, clksrc_base + PITTCTRL);
60+
writel(~0UL, clksrc_base + PITLDVAL);
61+
writel(PITTCTRL_TEN, clksrc_base + PITTCTRL);
6262

6363
sched_clock_register(pit_read_sched_clock, 32, rate);
6464
return clocksource_mmio_init(clksrc_base + PITCVAL, "vf-pit", rate,
@@ -76,7 +76,7 @@ static int pit_set_next_event(unsigned long delta,
7676
* hardware requirement.
7777
*/
7878
pit_timer_disable();
79-
__raw_writel(delta - 1, clkevt_base + PITLDVAL);
79+
writel(delta - 1, clkevt_base + PITLDVAL);
8080
pit_timer_enable();
8181

8282
return 0;
@@ -125,8 +125,8 @@ static struct clock_event_device clockevent_pit = {
125125

126126
static int __init pit_clockevent_init(unsigned long rate, int irq)
127127
{
128-
__raw_writel(0, clkevt_base + PITTCTRL);
129-
__raw_writel(PITTFLG_TIF, clkevt_base + PITTFLG);
128+
writel(0, clkevt_base + PITTCTRL);
129+
writel(PITTFLG_TIF, clkevt_base + PITTFLG);
130130

131131
BUG_ON(request_irq(irq, pit_timer_interrupt, IRQF_TIMER | IRQF_IRQPOLL,
132132
"VF pit timer", &clockevent_pit));
@@ -183,7 +183,7 @@ static int __init pit_timer_init(struct device_node *np)
183183
cycle_per_jiffy = clk_rate / (HZ);
184184

185185
/* enable the pit module */
186-
__raw_writel(~PITMCR_MDIS, timer_base + PITMCR);
186+
writel(~PITMCR_MDIS, timer_base + PITMCR);
187187

188188
ret = pit_clocksource_init(clk_rate);
189189
if (ret)

0 commit comments

Comments
 (0)