Add some SCRAM tests and enable them on travis #2208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
charmander requested changes May 9, 2020
Adds tests for SCRAM if SCRAM_TEST_PGUSER and SCRAM_TEST_PGPASSWORD are defined. If not the tests are skipped (default).
Contributor Author
| Rebased and updated to remove the extra test helper commit as, per @charmander, it already exists in built-in asserts package. |
Owner
| this is wonderful, thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
First commit adds another test helper. Engines is node 8+ so async all the way!
Second commit adds a test for SCRAM auth. It's disabled by default. To run the test export SCRAM_TEST_PGUSER and SCRAM_TEST_PGPASSWORD env vars. The rest of the vars will inherit from the default PG% config.
Third commit enables the SCRAM test in it's own matrix build. Could probably clean this up later to piggy back on an existing combo but for now I didn't want to break anything. Also, to check if we're actually using SCRAM it adds listeners to the underlying connection so test only runs on pure-JS for now.