Improve race condition in pg-native cancel test #3234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sehrope reviewed Jun 4, 2024
| var client = new Client() | ||
| client.connectSync() | ||
| client.query('SELECT pg_sleep(100);', function (err) { | ||
| client.query('SELECT pg_sleep(1000);', function (err) { |
Contributor
There was a problem hiding this comment.
The arg to pg_sleep(...) is seconds so changing from 100 to 1000 would not be relevant.
I think what you need to do is raise the 100 milliseconds (not seconds) below on line 16 to give the DB more time to start this command. The race that's happening is that the query has not started before 100ms, not that it's not running for long enough.
Owner Author
| ohhhh good point about the pg_sleep being in seconds - totally forgot about that. I'll let the 100ms timeout ride for now to send the cancel (as before there was NO timeout) and if it bugs again I'll increase it. Appreciate the eyes on things!! ❤️ hope everything is groovy & you can make it down yonder soon :) …On Tue, Jun 4, 2024 at 4:00 PM Sehrope Sarkuni ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/pg-native/test/cancel.js <#3234 (comment)> : > @@ -5,13 +5,15 @@ describe('cancel query', function () { it('works', function (done) { var client = new Client() client.connectSync() - client.query('SELECT pg_sleep(100);', function (err) { + client.query('SELECT pg_sleep(1000);', function (err) { The arg to pg_sleep(...) is seconds so changing from 100 to 1000 would not be relevant. I think what you need to do is raise the 100 milliseconds (not seconds) below on line 16 to give the DB more time to start this command. The race that's happening is that the query has not started before 100ms, not that it's not running for long enough. — Reply to this email directly, view it on GitHub <#3234 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAMHIKE35SJPSZT6SGFZRLZFYTHDAVCNFSM6AAAAABIY35KCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJXGM3TQMJVGM> . You are receiving this because you modified the open/close state.Message ID: ***@***.***> |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since the pg-native tests run more now the race condition is more apparent. In CI I think the query doesn't have time to get to the backend sometimes before the cancel is executed. This should give it more time. Still somewhat of a race condition possible, but much less likely. Also removed unneeded non-dev dependency in pg-native.