enable instrumentation of Client used in pool #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| I know what you're saying - I'm really sorry that the newrelic instrumentation was broken! I'll merge this for now. Would you be able to put together a unit test exercising this functionality so I don't break it again in the future? A separate PR for the test is fine. :) I'll push a patch version out to npm today. |
Contributor Author
| @brianc Yes, I will open a new PR for adding a test. Thanks for merging this in! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit broke the newrelic instrumentation since the Client constructor used in pool is now hidden and cannot be instrumented.
a8bd44a
This is a quick fix to unblock any users using pg native and pooling with newrelic. I am open to working on a better way to instrument as a follow up, if this is not optimal.