Consumer with support #1444
Open
Consumer with support #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
It's declared as a function with no args (just `self`), but actually takes a second argument which it ignores. I've corrected the function signature to match the declaration.
|
Kris Jenkins seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
krisajenkins force-pushed the consumer-with-support branch from cb0bd4b to ae2074e Compare added 2 commits October 21, 2022 16:02
Creating a consumer using a `with` statement: ```python with Consumer(...) as c: c.subscribe(...) ... ``` ...ensures that the consumer will be automatically closed when the block exits. There is no longer any need for a `finally: close()` block. This change makes it easier for beginners and experts alike to use consumers correctly and cleanly. The fact that it's less to type is a nice bonus. `with` has been a part of Python since v2.5 and is the recommended way to manage resource lifecycles.
Let's start people off on the right footing. (Note to reviewer - these changes are easier to review if you hide whitespace changes.)
krisajenkins force-pushed the consumer-with-support branch from fef087a to e184321 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adding
withsupport for consumers.Creating a consumer using a
withstatement:...ensures that the consumer will be automatically closed when the block exits. There is no longer any need for a
finally: close()block.This change makes it easier for beginners and experts alike to use consumers correctly and cleanly. The fact that it's less to type is a nice bonus.
withhas been a part of Python since v2.5 and is the recommended way to manage resource lifecycles.