[AccelTable][NFC] Fix typos and duplicated code (llvm#76155)

Renaming a member variable from "Endoding" to "Encoding". Also replace inlined code for "isNormalized" with a call to the function, so that if the definition of normalization ever changes, we only need to change the one place.

Author: felipepiovezan

llvm/include/llvm/CodeGen/AccelTable.h

@@ -270,16 +270,14 @@ class DWARF5AccelTableData : public AccelTableData {
 #endif
 
  uint64_t getDieOffset() const {
- assert(std::holds_alternative<uint64_t>(OffsetVal) &&
- "Accessing DIE Offset before normalizing.");
+ assert(isNormalized() && "Accessing DIE Offset before normalizing.");
  return std::get<uint64_t>(OffsetVal);
  }
  unsigned getDieTag() const { return DieTag; }
  unsigned getUnitID() const { return UnitID; }
  bool isTU() const { return IsTU; }
  void normalizeDIEToOffset() {
- assert(std::holds_alternative<const DIE *>(OffsetVal) &&
- "Accessing offset after normalizing.");
+ assert(!isNormalized() && "Accessing offset after normalizing.");
  OffsetVal = std::get<const DIE *>(OffsetVal)->getOffset();
  }
  bool isNormalized() const {
@@ -309,7 +307,7 @@ class DWARF5AccelTable : public AccelTable<DWARF5AccelTableData> {
 public:
  struct UnitIndexAndEncoding {
  unsigned Index;
- DWARF5AccelTableData::AttributeEncoding Endoding;
+ DWARF5AccelTableData::AttributeEncoding Encoding;
  };
  /// Returns type units that were constructed.
  const TUVectorTy &getTypeUnitsSymbols() { return TUSymbolsOrHashes; }

llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp

@@ -412,7 +412,7 @@ static uint32_t constructAbbreviationTag(
  const std::optional<DWARF5AccelTable::UnitIndexAndEncoding> &EntryRet) {
  uint32_t AbbrvTag = 0;
  if (EntryRet)
- AbbrvTag |= 1 << EntryRet->Endoding.Index;
+ AbbrvTag |= 1 << EntryRet->Encoding.Index;
  AbbrvTag |= 1 << dwarf::DW_IDX_die_offset;
  AbbrvTag |= Tag << LowerBitSize;
  return AbbrvTag;
@@ -429,7 +429,7 @@ void Dwarf5AccelTableWriter<DataT>::populateAbbrevsMap() {
  if (Abbreviations.count(AbbrvTag) == 0) {
  SmallVector<DWARF5AccelTableData::AttributeEncoding, 2> UA;
  if (EntryRet)
- UA.push_back(EntryRet->Endoding);
+ UA.push_back(EntryRet->Encoding);
  UA.push_back({dwarf::DW_IDX_die_offset, dwarf::DW_FORM_ref4});
  Abbreviations.try_emplace(AbbrvTag, UA);
  }