Skip to content

Commit 8186888

Browse files
authored
PIR: Remove TODO for pixels (#7209)
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211877701264248?focus=true ### Description Removes the TODO to add special handling for opt outs removed by user when it comes to pixels. It's not needed as we mark that opt out as deprecated and it's status is REMOVED_BY_USER meaning it won't be picked up for pixel processing. Additionally, the related extracted profiles are marked as deprecated, so they also won't be picked up. ### Steps to test this PR QA is optional - you can run a new scan and wait until opt outs are submitted, trigger the weekly pixel, then remove a record from dashboard and trigger the weekly pixel again. The removed profile should not be counted. ### UI changes No UI changes
1 parent 686ed6e commit 8186888

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pir/pir-impl/src/main/java/com/duckduckgo/pir/impl/pixels/OptOutConfirmationReporter.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class RealOptOutConfirmationReporter @Inject constructor(
4949
withContext(dispatcherProvider.io()) {
5050
val activeBrokers = pirRepository.getAllActiveBrokerObjects().associateBy { it.name }
5151
val allValidRequestedOptOutJobs = pirSchedulingRepository.getAllValidOptOutJobRecords().filter {
52-
it.status == REQUESTED || it.status == REMOVED // TODO: Filter out removed by user
52+
it.status == REQUESTED || it.status == REMOVED
5353
}
5454

5555
if (activeBrokers.isEmpty() || allValidRequestedOptOutJobs.isEmpty()) return@withContext

0 commit comments

Comments
 (0)