Skip to content

Commit 86355d0

Browse files
authored
Bump opentelemetry java sdk version and add new semconv dependency (#217)
* Bumping OTel sdk and adding semconv lib * Updating unit tests * Updating changelog * Updated notice files
1 parent ad337e2 commit 86355d0

File tree

24 files changed

+63
-63
lines changed

24 files changed

+63
-63
lines changed

CHANGELOG.asciidoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ ${next_release_notes}
3838
* Removing Gradle's warning on missing serverUrl param: {pull}209[#209]
3939
* Adding http response content length attr to okhttp spans: {pull}211[#211]
4040
* Marking okhttp spans as failed when receiving an error response code: {pull}212[#212]
41+
* Bumping OTel SDK to 1.31.0 and adding new semconv dependency: {pull}217[#217]
4142
////
4243
4344
[[release-notes-0.9.0]]

NOTICE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ This product includes software licensed under the 'Apache License Version 2.0' l
1616
- okhttp (https://square.github.io/okhttp/)
1717
- OpenTelemetry Java (https://github.com/open-telemetry/opentelemetry-java)
1818
- OpenTelemetry Java Contrib (https://github.com/open-telemetry/opentelemetry-java-contrib)
19+
- OpenTelemetry Semantic Conventions Java (https://github.com/open-telemetry/semantic-conventions-java)
1920
- org.stagemonitor:stagemonitor-configuration (http://www.stagemonitor.org)
2021
- Weakly referenced lock-free data structures (https://github.com/raphw/weak-lock-free)
2122

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
dependencies.hash=83E0E6D9CD40065C79FADBCA67A5607B
1+
dependencies.hash=81F0B6D19D5388F15DBE3E189D6C1B22

android-sdk/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ dependencies {
4444
implementation 'com.blogspot.mydailyjava:weak-lock-free:0.18'
4545
implementation project(':android-common')
4646
implementation "io.opentelemetry:opentelemetry-exporter-otlp:$openTelemetry_version"
47-
implementation "io.opentelemetry:opentelemetry-semconv:$openTelemetry_version-alpha"
47+
implementation "io.opentelemetry.semconv:opentelemetry-semconv:1.21.0-alpha"
4848
implementation "io.opentelemetry.contrib:opentelemetry-disk-buffering:$openTelemetry_version-alpha"
4949
implementation "androidx.annotation:annotation:$androidAnnotations_version"
5050
implementation 'com.dslplatform:dsl-json-java8:1.10.0'
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
dependencies.hash=553460B56887EDB98C3A019266F71C55
1+
dependencies.hash=81E0A693875E87899494D84AB8C8D79D

android-sdk/src/main/java/co/elastic/apm/android/sdk/attributes/common/CarrierHttpAttributesVisitor.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import co.elastic.apm.android.sdk.internal.services.network.data.CarrierInfo;
2626
import co.elastic.apm.android.sdk.internal.utilities.providers.Provider;
2727
import io.opentelemetry.api.common.AttributesBuilder;
28-
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
28+
import io.opentelemetry.semconv.SemanticAttributes;
2929

3030
public class CarrierHttpAttributesVisitor implements AttributesVisitor {
3131
private final Provider<NetworkService> networkServiceProvider;
@@ -38,10 +38,10 @@ public CarrierHttpAttributesVisitor() {
3838
public void visit(AttributesBuilder builder) {
3939
CarrierInfo carrierInfo = networkServiceProvider.get().getCarrierInfo();
4040
if (carrierInfo != null) {
41-
builder.put(SemanticAttributes.NET_HOST_CARRIER_NAME, carrierInfo.name);
42-
builder.put(SemanticAttributes.NET_HOST_CARRIER_MCC, carrierInfo.mcc);
43-
builder.put(SemanticAttributes.NET_HOST_CARRIER_MNC, carrierInfo.mnc);
44-
builder.put(SemanticAttributes.NET_HOST_CARRIER_ICC, carrierInfo.icc);
41+
builder.put(SemanticAttributes.NETWORK_CARRIER_NAME, carrierInfo.name);
42+
builder.put(SemanticAttributes.NETWORK_CARRIER_MCC, carrierInfo.mcc);
43+
builder.put(SemanticAttributes.NETWORK_CARRIER_MNC, carrierInfo.mnc);
44+
builder.put(SemanticAttributes.NETWORK_CARRIER_ICC, carrierInfo.icc);
4545
}
4646
}
4747
}

android-sdk/src/main/java/co/elastic/apm/android/sdk/attributes/common/ConnectionHttpAttributesVisitor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import co.elastic.apm.android.sdk.internal.services.network.NetworkService;
2525
import co.elastic.apm.android.sdk.internal.services.network.data.type.NetworkType;
2626
import io.opentelemetry.api.common.AttributesBuilder;
27-
import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
27+
import io.opentelemetry.semconv.SemanticAttributes;
2828

2929
public class ConnectionHttpAttributesVisitor implements AttributesVisitor {
3030
private final NetworkService networkService;
@@ -48,9 +48,9 @@ private ConnectionHttpAttributesVisitor() {
4848
@Override
4949
public void visit(AttributesBuilder builder) {
5050
NetworkType networkType = networkService.getType();
51-
builder.put(SemanticAttributes.NET_HOST_CONNECTION_TYPE, networkType.getName());
51+
builder.put(SemanticAttributes.NETWORK_CONNECTION_TYPE, networkType.getName());
5252
if (networkType.getSubTypeName() != null) {
53-
builder.put(SemanticAttributes.NET_HOST_CONNECTION_SUBTYPE, networkType.getSubTypeName());
53+
builder.put(SemanticAttributes.NETWORK_CONNECTION_SUBTYPE, networkType.getSubTypeName());
5454
}
5555
}
5656
}

android-sdk/src/main/java/co/elastic/apm/android/sdk/attributes/resources/DeviceIdVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import co.elastic.apm.android.sdk.internal.services.ServiceManager;
2626
import co.elastic.apm.android.sdk.internal.services.preferences.PreferencesService;
2727
import io.opentelemetry.api.common.AttributesBuilder;
28-
import io.opentelemetry.semconv.resource.attributes.ResourceAttributes;
28+
import io.opentelemetry.semconv.ResourceAttributes;
2929

3030
public class DeviceIdVisitor implements AttributesVisitor {
3131

android-sdk/src/main/java/co/elastic/apm/android/sdk/attributes/resources/DeviceInfoVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
import co.elastic.apm.android.sdk.attributes.AttributesVisitor;
2424
import io.opentelemetry.api.common.AttributesBuilder;
25-
import io.opentelemetry.semconv.resource.attributes.ResourceAttributes;
25+
import io.opentelemetry.semconv.ResourceAttributes;
2626

2727
public class DeviceInfoVisitor implements AttributesVisitor {
2828

android-sdk/src/main/java/co/elastic/apm/android/sdk/attributes/resources/OsDescriptorVisitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
import co.elastic.apm.android.sdk.attributes.AttributesVisitor;
2424
import io.opentelemetry.api.common.AttributesBuilder;
25-
import io.opentelemetry.semconv.resource.attributes.ResourceAttributes;
25+
import io.opentelemetry.semconv.ResourceAttributes;
2626

2727
public class OsDescriptorVisitor implements AttributesVisitor {
2828

0 commit comments

Comments
 (0)