fix(rum-core): add default timeout for xhr post requests

[JH108]

Added a default timeout to the makeHttpRequest method on apm-server
in the case, a payload or headers are passed to the function. Previously
the default timeout would only be applied if the third parameter was
not defined.

This will resolve the issue for #896

[ghost]

💚 Build Succeeded

Expand to view the summary

Build stats

• Build Cause: [Started by user Vignesh Shanmugam, Replayed #4]

• Start Time: 2020-09-16T14:54:31.978+0000

• Duration: 75 min 58 sec

Test stats 🧪

Test	Results
Failed	0
Passed	1016
Skipped	10
Total	1026

Steps errors

Expand to view the steps failures

• Name: Start Elastic Stack 8.0.0-SNAPSHOT - @elastic/apm-rum-core - saucelabs

  • Description:

  • Duration: 7 min 33 sec

  • Start Time: 2020-09-16T15:20:35.348+0000

  • log

• Name: Error signal

  • Description:

  • Duration: 0 min 0 sec

  • Start Time: 2020-09-16T15:27:08.206+0000

  • log

[vigneshshanmugam]

Nice find, thanks a lot for digging the code. Could you change it to {timeout = 10000, payload, headers } = {} instead. Both should do the same job.

[JH108]

Thanks! Yep, that will be cleaner. I made the change and it should be ready for review again.

[vigneshshanmugam]

Looks good, Thanks once again @JH108

[ghost]

📦 Bundlesize report

Filename	Size(bundled)	Size(gzip)	Diff(gzip)
elastic-apm-opentracing.umd.min.js	61.1 KiB	19.4 KiB	⚠️ 1 Byte
elastic-apm-rum.umd.min.js	55.1 KiB	17.9 KiB	💚 0 Bytes