fix: null is not an object (evaluating 'reason.message') #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
💔 Build Failed
Expand to view the summary
Build stats
Steps errors Expand to view the steps failures
|
Contributor Author
| Sorry for introducing the bug from commit 716d168. |
Member
vigneshshanmugam left a comment
vigneshshanmugam left a comment There was a problem hiding this comment.
No worries, good catch. Can you add a test case for the same as part of the same test?
Contributor Author
| Done, and the Travis CI passed. |
vigneshshanmugam approved these changes Dec 1, 2020
Member
vigneshshanmugam left a comment
vigneshshanmugam left a comment There was a problem hiding this comment.
Thanks @clyfish Will merge once our CI passes.
📦 Bundlesize report
|
Codecov Report
@@ Coverage Diff @@ ## master #940 +/- ## ========================================== + Coverage 92.86% 92.93% +0.06% ========================================== Files 47 47 Lines 2300 2322 +22 Branches 466 472 +6 ========================================== + Hits 2136 2158 +22 Misses 161 161 Partials 3 3
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #940 +/- ## ========================================== + Coverage 92.86% 92.93% +0.06% ========================================== Files 47 47 Lines 2300 2322 +22 Branches 466 472 +6 ========================================== + Hits 2136 2158 +22 Misses 161 161 Partials 3 3
🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When reason is null, apm sdk crashes on evaluating
reason.message.