Remove cluster state from /_cluster/reroute response #114231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DaveCTurner added >breaking :Distributed Coordination/Allocation 
Collaborator
| Hi @DaveCTurner, I've created a changelog YAML for you. Note that since this PR is labelled |
Including the cluster state in responses to the `POST _cluster/state` API was deprecated in elastic#90399 (v8.6.0) requiring callers to pass `?metric=none` to avoid the deprecation warning. This commit adjusts the behaviour as promised in v9 so that this API never returns the cluster state, and deprecates the `?metric` parameter itself. Closes elastic#88978
DaveCTurner force-pushed the 2024/10/07/ignore-reroute-metric-parameter branch from 49a36ea to 413eb3f Compare 
elasticsearchmachine added the Team:Distributed (Obsolete) Collaborator
| Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko reviewed Oct 8, 2024
| * To be removed when REST compatibility with {@link org.elasticsearch.Version#V_8_6_0} / {@link RestApiVersion#V_8} no longer needed | ||
| */ | ||
| @UpdateForV9(owner = UpdateForV9.Owner.DISTRIBUTED_COORDINATION) // to remove from the v9 API only | ||
| @UpdateForV10(owner = UpdateForV10.Owner.DISTRIBUTED_COORDINATION) // to remove entirely |
Contributor
There was a problem hiding this comment.
I do not think this pr closes #88978, until this is removed in 10, is it?
Contributor Author
There was a problem hiding this comment.
I think it does - at least from the users' perspective with this change we no longer return the cluster state as described in #88978. There's some tech debt left behind (because of the need to support the v8 API still) but that's tracked with the @UpdateForV10 annotation, we don't need to keep an issue open too.
idegtiarenko approved these changes Oct 8, 2024
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 10, 2024
Including the cluster state in responses to the `POST _cluster/state` API was deprecated in elastic#90399 (v8.6.0) requiring callers to pass `?metric=none` to avoid the deprecation warning. This commit adjusts the behaviour as promised in v9 so that this API never returns the cluster state, and deprecates the `?metric` parameter itself. Closes elastic#88978
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
Including the cluster state in responses to the `POST _cluster/state` API was deprecated in elastic#90399 (v8.6.0) requiring callers to pass `?metric=none` to avoid the deprecation warning. This commit adjusts the behaviour as promised in v9 so that this API never returns the cluster state, and deprecates the `?metric` parameter itself. Closes elastic#88978
Contributor
| @DaveCTurner is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
Contributor Author
| No, the reroute API is internal, end-users cannot access it in serverless. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Including the cluster state in responses to the
POST _cluster/stateAPI was deprecated in #90399 (v8.6.0) requiring callers to pass
?metric=noneto avoid the deprecation warning. This commit adjusts thebehaviour as promised in v9 so that this API never returns the cluster
state, and deprecates the
?metricparameter itself.Closes #88978