Skip to content

Conversation

@benwtrent
Copy link
Member

Removes the old _knn_search API that was never out of tech preview and deprecated throughout the v8 cycle.

To utilize the API, compatible-with=8 can be utilized.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Dec 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @benwtrent, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent
Copy link
Member Author

@elastic/docs This removes a documentation page as the API is no longer generally accessible in v9.

Do we need to auto-forward the page? Can we do that in our docs?

@shainaraskas
Copy link
Contributor

@benwtrent we do soft redirects by adding an entry to this page - that will unblock this PR. we then need to make a request to the web team to get a proper redirect put in place.

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>

public RestKnnSearchAction() {}

@UpdateForV9(owner = UpdateForV9.Owner.SEARCH_RELEVANCE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment to remove this handler for V10?

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben, nice code cleanup

@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 10, 2024
@elasticsearchmachine elasticsearchmachine merged commit 645657c into elastic:main Dec 10, 2024
16 checks passed
@benwtrent benwtrent deleted the knn-search-api/deprecation-for-removal branch December 10, 2024 15:01
@leemthompo
Copy link
Contributor

@benwtrent is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >breaking :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.0.0

6 participants