Adjust random_score default field to _seq_no field #118671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
benwtrent added >breaking :Search Relevance/Search 
elasticsearchmachine added the Team:Search Relevance 
Collaborator
| Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
| Hi @benwtrent, I've created a changelog YAML for you. Note that since this PR is labelled |
mark-vieira approved these changes Dec 13, 2024
javanna approved these changes Dec 17, 2024
Member
javanna left a comment
javanna left a comment There was a problem hiding this comment.
LGTM I just reviewed the leftover deprecation logger usages and this looked like one that can be addressed, thanks for taking care of it.
benwtrent added the auto-merge-without-approval rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Dec 18, 2024
In an effort to improve performance and continue to provide unique seeded scores for documents in the same index, we are switching from _id to _seq_no. Requiring a field that is "unique" for a field and to help with random scores is burdensome for the user. So, we should default to a unique field (per index) when the user provides a seed. Using `_seq_no` should be better as: - We don't have to grab stored fields values - Bytes used are generally smaller Additionally this removes the deprecation warning. Marking as "breaking" as it does change the scores & behavior, but the API provide is the same.
Contributor
| @benwtrent is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In an effort to improve performance and continue to provide unique seeded scores for documents in the same index, we are switching from _id to _seq_no.
Requiring a field that is "unique" for a field and to help with random scores is burdensome for the user. So, we should default to a unique field (per index) when the user provides a seed.
Using
_seq_noshould be better as:Additionally this removes the deprecation warning.
Marking as "breaking" as it does change the scores & behavior, but the API provide is the same.