Remove support for types field in watcher search #120748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PeteGillinElastic force-pushed the remove-watcher-types-support-removal branch 2 times, most recently from c16d860 to 12aa3be Compare 
Collaborator
| Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled |
In 8.x, setting the `input.search.request.types` field in the payload when creating a watcher to an empty array was allowed, although it resulted in a deprecation warning and had no effect (and any value other than an empty array would result in an error). In 9.x, support for this field is entirely removed, and the empty array will also result in an error. We have already introduced a script to be run as part of the upgrade which removes the field from existing watches in elastic#120371. This also removes an unrelated TODO in passing, because we are not going to do that (the functionality it refers to exists and is not deprecated so cannot be removed).
PeteGillinElastic force-pushed the remove-watcher-types-support-removal branch from a2b438b to 70b6a91 Compare Collaborator
| Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine added the Team:Data Management 
| ElasticsearchParseException.class, | ||
| () -> WatcherSearchTemplateRequest.fromXContent(parser, randomFrom(SearchType.values())) | ||
| ); | ||
| assertThat(e.getMessage(), is("could not read search request. unexpected array field [types]")); |
Member Author
There was a problem hiding this comment.
I wasn't sure whether to keep these tests and assert that parsing fails or not. I'm open to removing them if anyone would prefer it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In 8.x, setting
input.search.request.typesto an empty array was allowed, although it resulted in a deprecation warning and had no effect (and any value other than an empty array would result in an error).In 9.x, support for this field is entirely removed, and the empty array will also result in an error.
We have already introduced a script to be run as part of the upgrade which removes the field from existing watches in
#120371.