Allow partial results by default in ES|QL #125060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dnhatn force-pushed the enable-partial-results branch 4 times, most recently from cfd1592 to d42e976 Compare dnhatn force-pushed the enable-partial-results branch 4 times, most recently from f21845b to c3c8e3e Compare 
elasticsearchmachine added the serverless-linked 
dnhatn force-pushed the enable-partial-results branch from c3c8e3e to 6fe39e8 Compare 
Collaborator
| Hi @dnhatn, I've created a changelog YAML for you. Note that since this PR is labelled |
dnhatn added v8.19.0 auto-backport Collaborator
| Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine added the Team:Analytics 
dnhatn commented Apr 3, 2025
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/EsqlPlugin.java Show resolved Hide resolved
10 tasks
Contributor
| I saw in #122802 there is one thing before enabling the default:
Is this done or should it be done after this? |
smalyshev reviewed Apr 3, 2025
smalyshev reviewed Apr 3, 2025
docs/changelog/125060.yaml Outdated
| summary: Allow partial results by default in ES|QL | ||
| area: ES|QL | ||
| type: breaking | ||
| issues: [] |
smalyshev approved these changes Apr 3, 2025
Member Author
| @smalyshev Thanks for the review. |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Apr 4, 2025
With this change, ES|QL will return partial results instead of failing the entire query when encountering errors. Callers should check the partial_results flag in the response to determine if the result is partial or complete. If returning partial results is not desired, this option can be overridden per request via the allow_partial_results parameter in the query URL or globally via the cluster setting esql.allow_partial_results. Relates elastic#122802
alex-spies added a commit to alex-spies/elasticsearch that referenced this pull request Apr 4, 2025
This reverts commit 81555cc.
elasticsearchmachine pushed a commit that referenced this pull request Apr 4, 2025
…126286) This reverts commit 81555cc from #125060. Fix #126275 @idegtiarenko and I investigated and believe this needs reverting: silently dropping results from the query response in case any index is missing can lead to real problems if users don't spot their mistake. I'm also not sure if all the results will get dropped, or only from some nodes/shards/clusters, meaning that this might be hard to spot by users if only some results get dropped. The main PR has no transport version bump, no new ESQL capability, and was merged 15h ago - so it should be safe to just revert it. I noticed there was a linked Serverless PR on the original PR, but it merely disabled some obsolete tests on Serverless and doesn't require reverting itself.
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Apr 9, 2025
With this change, ES|QL will return partial results instead of failing the entire query when encountering errors. Callers should check the partial_results flag in the response to determine if the result is partial or complete. If returning partial results is not desired, this option can be overridden per request via the allow_partial_results parameter in the query URL or globally via the cluster setting esql.allow_partial_results. Relates elastic#122802
andreidan pushed a commit to andreidan/elasticsearch that referenced this pull request Apr 9, 2025
…)" (elastic#126286) This reverts commit 81555cc from elastic#125060. Fix elastic#126275 @idegtiarenko and I investigated and believe this needs reverting: silently dropping results from the query response in case any index is missing can lead to real problems if users don't spot their mistake. I'm also not sure if all the results will get dropped, or only from some nodes/shards/clusters, meaning that this might be hard to spot by users if only some results get dropped. The main PR has no transport version bump, no new ESQL capability, and was merged 15h ago - so it should be safe to just revert it. I noticed there was a linked Serverless PR on the original PR, but it merely disabled some obsolete tests on Serverless and doesn't require reverting itself.
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Apr 24, 2025
…tic#125060)" (elastic#126286)" This reverts commit 8f38b13. Restore changes from elastic#125060 now that the breakage should be fixed.
smalyshev added a commit that referenced this pull request Apr 28, 2025
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Apr 28, 2025
* Revert "ESQL: Revert "Allow partial results by default in ES|QL (elastic#125060)" (elastic#126286)" This reverts commit 8f38b13. Restore changes from elastic#125060 now that the breakage should be fixed. (cherry picked from commit eb479e5) # Conflicts: # docs/release-notes/breaking-changes.md # x-pack/plugin/build.gradle # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ClusterComputeHandler.java
elasticsearchmachine pushed a commit that referenced this pull request Apr 28, 2025
…127474) * Allow partial results by default in ES|QL - Take 2 (#127351) * Revert "ESQL: Revert "Allow partial results by default in ES|QL (#125060)" (#126286)" This reverts commit 8f38b13. Restore changes from #125060 now that the breakage should be fixed. (cherry picked from commit eb479e5) # Conflicts: # docs/release-notes/breaking-changes.md # x-pack/plugin/build.gradle # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ClusterComputeHandler.java * skip test * fix test * fix test
dnhatn removed >breaking backport pending Team:Analytics Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With this change, ES|QL will return partial results instead of failing the entire query when encountering errors. Callers should check the
partial_resultsflag in the response to determine if the result is partial or complete. If returning partial results is not desired, this option can be overridden per request via theallow_partial_resultsparameter in the query URL or globally via the cluster settingesql.allow_partial_results.Relates #122802