Fix inference fields handling on old indices #136312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Mikep86 added >bug :SearchOrg/Relevance 
elasticsearchmachine added the Team:Search - Relevance 
Collaborator
| Pinging @elastic/search-relevance (Team:Search - Relevance) |
Collaborator
| Hi @Mikep86, I've created a changelog YAML for you. |
jimczi approved these changes Oct 9, 2025
Contributor
jimczi left a comment
jimczi left a comment There was a problem hiding this comment.
Left a comment/question. LGTM otherwise
server/src/main/java/org/elasticsearch/index/get/ShardGetService.java Outdated Show resolved Hide resolved
Mikep86 added the auto-backport Collaborator
| Hi @Mikep86, I've updated the changelog YAML for you. |
Contributor Author
| @elasticmachine update branch |
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Oct 9, 2025
Collaborator
💚 Backport successful
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes cases where
_inference_fieldswas included in_sourcewhen it shouldn't have been on indices created prior to #131907. Moreover, If_sourcewas disabled in the request, it caused the query failure described in #136130.Randomized unit and integration tests have also been added to provide more robust test coverage and avoid regressions in this area.