Skip to content

Commit 3a96938

Browse files
committed
Resolved comments provided by @kcreddy.
1. Reverted the resource.id mapping. 2. Added external: ecs inside ecs.yml. 3. Removed non-required comment from the transform.yml file.
1 parent 27e6321 commit 3a96938

File tree

6 files changed

+15
-12
lines changed

6 files changed

+15
-12
lines changed

packages/aws/data_stream/config/_dev/test/pipeline/test-event.log-expected.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@
9595
]
9696
},
9797
"resource": {
98-
"id": "arn:aws:config:us-east-1:329599655752:config-rule/config-rule-rwpvuz",
98+
"id": "i-0a4468fbfafee6a8f",
9999
"type": "AWS::EC2::Instance"
100100
},
101101
"result": {

packages/aws/data_stream/config/elasticsearch/ingest_pipeline/default.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -311,8 +311,8 @@ processors:
311311
ignore_missing: true
312312
- set:
313313
field: resource.id
314-
tag: set_resource_id_from_config_config_rule_info_config_rule_arn
315-
copy_from: aws.config.rule_info.config_rule_arn
314+
tag: set_resource_id_from_config_evaluation_result_identifier_evaluation_result_qualifier_resource_id
315+
copy_from: aws.config.evaluation_result_identifier.evaluation_result_qualifier.resource_id
316316
ignore_empty_value: true
317317
- rename:
318318
field: json.EvaluationResultIdentifier.EvaluationResultQualifier.ResourceType
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
- name: cloud.provider
22
type: constant_keyword
3+
external: ecs
34
- name: observer.vendor
45
type: constant_keyword
6+
external: ecs

packages/aws/data_stream/config/sample_event.json

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
2-
"@timestamp": "2025-05-16T07:58:23.791Z",
2+
"@timestamp": "2025-05-20T07:12:28.179Z",
33
"agent": {
4-
"ephemeral_id": "6fbe87e6-993e-4c40-abbe-bbe39ee3591c",
5-
"id": "7d2ce287-1db4-4b2d-99f9-a00c406e3c06",
6-
"name": "elastic-agent-65400",
4+
"ephemeral_id": "315016b1-7512-4599-9b25-575562a9e817",
5+
"id": "44507658-5b33-414c-b7fc-2e3fa9c24417",
6+
"name": "elastic-agent-66460",
77
"type": "filebeat",
88
"version": "8.18.0"
99
},
@@ -52,14 +52,14 @@
5252
},
5353
"data_stream": {
5454
"dataset": "aws.config",
55-
"namespace": "55739",
55+
"namespace": "59551",
5656
"type": "logs"
5757
},
5858
"ecs": {
5959
"version": "8.17.0"
6060
},
6161
"elastic_agent": {
62-
"id": "7d2ce287-1db4-4b2d-99f9-a00c406e3c06",
62+
"id": "44507658-5b33-414c-b7fc-2e3fa9c24417",
6363
"snapshot": false,
6464
"version": "8.18.0"
6565
},
@@ -70,7 +70,7 @@
7070
],
7171
"created": "2015-09-29T15:52:31.883Z",
7272
"dataset": "aws.config",
73-
"ingested": "2025-05-16T07:58:26Z",
73+
"ingested": "2025-05-20T07:12:30Z",
7474
"kind": "event",
7575
"original": "{\"ComplianceType\":\"COMPLIANT\",\"ConfigRuleInfo\":{\"ConfigRuleArn\":\"arn:aws:config:us-east-1:11223344556:config-rule/config-rule-id1\",\"ConfigRuleId\":\"config-rule-id1\",\"ConfigRuleName\":\"access-keys-rotated\",\"ConfigRuleState\":\"ACTIVE\",\"Description\":\"Checks whether the active access keys are rotated within the number of days specified in maxAccessKeyAge. The rule is non-compliant if the access keys have not been rotated for more than maxAccessKeyAge number of days.\",\"EvaluationModes\":[{\"Mode\":\"DETECTIVE\"}],\"InputParameters\":\"{\\\"maxAccessKeyAge\\\":\\\"90\\\"}\",\"MaximumExecutionFrequency\":\"TwentyFour_Hours\",\"Source\":{\"Owner\":\"AWS\",\"SourceIdentifier\":\"ACCESS_KEYS_ROTATED\"}},\"ConfigRuleInvokedTime\":1444799479.852,\"EvaluationResultIdentifier\":{\"EvaluationResultQualifier\":{\"ConfigRuleName\":\"access-keys-rotated\",\"EvaluationMode\":\"DETECTIVE\",\"ResourceId\":\"i-0a4468fbfafeeg20h\",\"ResourceType\":\"AWS::EC2::Instance\"},\"OrderingTimestamp\":1443541951.883},\"ResultRecordedTime\":1444799480.061}",
7676
"outcome": "success",
@@ -87,7 +87,7 @@
8787
"vendor": "Amazon"
8888
},
8989
"resource": {
90-
"id": "arn:aws:config:us-east-1:11223344556:config-rule/config-rule-id1",
90+
"id": "i-0a4468fbfafeeg20h",
9191
"type": "AWS::EC2::Instance"
9292
},
9393
"result": {
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
- name: cloud.provider
22
type: constant_keyword
3+
external: ecs
34
- name: observer.vendor
45
type: constant_keyword
6+
external: ecs

packages/aws/elasticsearch/transform/latest_config_misconfigurations/transform.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ description: >-
1717
Latest Configs from AWS. As configs get updated, this transform stores only the latest state of each config inside the destination index. Thus the transform's destination index contains only the latest state of the config.
1818
frequency: 5m
1919
settings:
20-
# This is required to prevent the transform from clobbering the Fleet-managed mappings.
2120
unattended: true
2221
sync:
2322
time:

0 commit comments

Comments
 (0)