Skip to content

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 8, 2024

Proposed commit message

This PR is to fix aws.metrics_names_fingerprint field: moving from metrics_names_fingerprint to aws.metrics_names_fingerprint.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng requested review from a team as code owners October 8, 2024 22:30
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 8, 2024
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Oct 8, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kaiyan-sheng
Copy link
Contributor Author

Sorry all for the mistake I made in the previous PR!!

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @kaiyan-sheng

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as code owner

@kaiyan-sheng kaiyan-sheng merged commit 5218dff into elastic:backport-aws-2.24 Oct 10, 2024
2 checks passed
@kaiyan-sheng kaiyan-sheng deleted the fix_fingerprint_field branch October 10, 2024 14:27
@elastic-vault-github-plugin-prod

Package aws - 2.24.3 containing this change is available at https://epr.elastic.co/search?package=aws

qcorporation pushed a commit that referenced this pull request Feb 4, 2025
* Fix aws.metrics_names_fingerprint field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:aws AWS Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

6 participants