- Notifications
You must be signed in to change notification settings - Fork 515
[azure] signinlogs - support additional category types #1721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andrewkroh merged 1 commit into elastic:master from andrewkroh:feature/azure/more-signinlogs-types Oct 12, 2021
Merged
[azure] signinlogs - support additional category types #1721
andrewkroh merged 1 commit into elastic:master from andrewkroh:feature/azure/more-signinlogs-types Oct 12, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Member Author
| /test |
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs. The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched a category of /^SignInLogs$/. Changes - Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this was done on field by field basis with rename processors. Now a script processor does it recursively on all fields. - Populate user_agent fields. - Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details. - Populate event.id with azure.signinlogs.properties.id. - Set source.address.
P1llus approved these changes Oct 12, 2021
Member
P1llus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Oct 18, 2021
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs. The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched a category of /^SignInLogs$/. Changes - Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this was done on field by field basis with rename processors. Now a script processor does it recursively on all fields. - Populate user_agent fields. - Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details. - Populate event.id with azure.signinlogs.properties.id. - Set source.address. Syncs changes from elastic/integrations#1721 to Beats. Relates elastic#23653
4 tasks
andrewkroh added a commit to elastic/beats that referenced this pull request Oct 19, 2021
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs. The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched a category of /^SignInLogs$/. Changes - Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this was done on field by field basis with rename processors. Now a script processor does it recursively on all fields. - Populate user_agent fields. - Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details. - Populate event.id with azure.signinlogs.properties.id. - Set source.address. Syncs changes from elastic/integrations#1721 to Beats. Relates #23653
andrewkroh added a commit to elastic/beats that referenced this pull request Oct 19, 2021
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs. The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched a category of /^SignInLogs$/. Changes - Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this was done on field by field basis with rename processors. Now a script processor does it recursively on all fields. - Populate user_agent fields. - Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details. - Populate event.id with azure.signinlogs.properties.id. - Set source.address. Syncs changes from elastic/integrations#1721 to Beats. Relates #23653
andrewkroh added a commit to elastic/beats that referenced this pull request Oct 19, 2021
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs. The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched a category of /^SignInLogs$/. Changes - Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this was done on field by field basis with rename processors. Now a script processor does it recursively on all fields. - Populate user_agent fields. - Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details. - Populate event.id with azure.signinlogs.properties.id. - Set source.address. Syncs changes from elastic/integrations#1721 to Beats. Relates #23653 Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs. The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched a category of /^SignInLogs$/. Changes - Convert azure field names from camel case to snake case to be consistent with our other fields. Previous this was done on field by field basis with rename processors. Now a script processor does it recursively on all fields. - Populate user_agent fields. - Flatten the key/value objects under azure.signinlogs.properties.authentication_processing_details. - Populate event.id with azure.signinlogs.properties.id. - Set source.address. Syncs changes from elastic/integrations#1721 to Beats. Relates elastic#23653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support and tests for ManagedIdentitySignInLogs, NonInteractiveUserSignInLogs, and ServicePrincipalSignInLogs.
The pipeline will process any logs that have category of /.*SignInLogs$/. It previously only processed logs that matched
a category of /^SignInLogs$/.
Changes
was done on field by field basis with rename processors. Now a script processor does it recursively on all fields.
Checklist
changelog.ymlfile.Related issues