[elastic_agent] Update compatiblity to be compatible with 8.0.x #2125
Conversation
I chose to make it compatible with 7.16.x and 8.0.x. It means we need to publish a new package for 8.1.0 and upwards. I did not want to use all 8.x compatibility as I was not sure it will hold true. This gives us some time to figure it out.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
packages/elastic_agent/manifest.yml Outdated
| categories: ["elastic_stack"] | ||
| conditions: | ||
| kibana.version: "^7.15.0" | ||
| kibana.version: "^7.16.0 || 8.0.x" |
There was a problem hiding this comment.
@mtojek Is it possible that this kind of strings is not supported at the moment by the validation? It should work with the golang lib used for semver.
There was a problem hiding this comment.
I think this should be ^7.16.0 || ^8.0.0, but our Jenkins pipelines don't support it yet, see elastic/apm-pipeline-library#1359
There was a problem hiding this comment.
Oh, to be compatible with all minors, the golang lib supports ~: ^7.16.0 || ~8.0.0, but we would also need to add support for this in the Jenkins pipelines to find the version to use for testing.
mtojek left a comment
mtojek left a comment There was a problem hiding this comment.
LGTM.
Please remember to promote the package to the production stage.
| I updated this PR based on my comment in elastic/elastic-package#571 (comment) Likely needs another round of review. |
| version: 1.3.0 | ||
| release: ga | ||
| description: Collect metrics from Elastic Agents. | ||
| description: Collect logs and metrics from Elastic Agents. |
| categories: ["elastic_stack"] | ||
| conditions: | ||
| kibana.version: "^7.15.0" | ||
| kibana.version: "^7.16.0 || ^8.0.0" |
There was a problem hiding this comment.
For fleet server you are using ^7.16.0 || ~8.0.0 now https://github.com/elastic/integrations/pull/2133/files#diff-74af037e0c513145506487bbcc03212b709b15b581a313e6dae23336681e78b5R11
Do we want a different thing for the agent?
There was a problem hiding this comment.
No, this is a "failure" on my end to push the changes I made in fleet-server too :-(
| Getting this in and promoting to staging. I'll push to production as soon as @andresrc also gives his 👍 |
| I'm 👍 for this package (and fleet server) the part I'm not sure if this is what we should do with all packages |
| Change for Apache package as example for other packages: #2122 |
5 participants
Make it compatible with 7.16 and 8.x