Skip to content

[GCP] Convert GCP Firestore metricset from lightweight #3798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2022
Merged

[GCP] Convert GCP Firestore metricset from lightweight #3798

merged 3 commits into from
Sep 19, 2022

Conversation

@legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Jul 21, 2022

What does this PR do?

Convert GCP Firestore metricset from lightweight

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@legoguy1000 legoguy1000 requested review from a team as code owners July 21, 2022 18:04
@elasticmachine
Copy link

elasticmachine commented Jul 21, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-19T18:36:40.828+0000

  • Duration: 18 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 82
Skipped 0
Total 82

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 1, 2022
kaiyan-sheng
kaiyan-sheng reviewed Sep 9, 2022
View reviewed changes
@legoguy1000 legoguy1000 force-pushed the 3722-gcp-firestore-lightweight branch from be9dc83 to 41fced2 Compare September 9, 2022 19:48
@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented Sep 9, 2022

/test
@elasticmachine
Copy link

elasticmachine commented Sep 9, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 90.816% (89/98) ❕
Lines 95.752% (1375/1436) ❕
Conditionals 100.0% (0/0) 💚
@legoguy1000
Copy link
Contributor Author

legoguy1000 commented Sep 16, 2022

Seems good to merge?
@legoguy1000 legoguy1000 force-pushed the 3722-gcp-firestore-lightweight branch from 28d4e4a to 76915c7 Compare September 19, 2022 18:36
@legoguy1000 legoguy1000 mentioned this pull request Sep 19, 2022
Merged
4 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 19, 2022

🚀 Benchmarks report

Package gcp 👍(4) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
loadbalancing_logs 3663 2801.12 -861.88 (-30.77%) 💔

To see the full report comment with /test benchmark fullreport
@kaiyan-sheng kaiyan-sheng merged commit f2408f1 into elastic:main Sep 19, 2022
@legoguy1000 legoguy1000 deleted the 3722-gcp-firestore-lightweight branch September 19, 2022 19:28
@andrewkroh andrewkroh mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

4 participants

@legoguy1000 @elasticmachine @kaiyan-sheng @endorama