Skip to content

Fix data_stream.dataset indentation on cloudwatch_logs integration #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2022
Merged

Fix data_stream.dataset indentation on cloudwatch_logs integration #3844

merged 2 commits into from
Jul 27, 2022

Conversation

@paolafrancesca
Copy link

@paolafrancesca paolafrancesca commented Jul 27, 2022

Bug

What does this PR do?

Fix data_stream.dataset indentation on cloudwatch_logs aws-cloudwatch.yml.hbs

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@paolafrancesca paolafrancesca requested a review from a team as a code owner July 27, 2022 02:52
@paolafrancesca paolafrancesca self-assigned this Jul 27, 2022
@paolafrancesca paolafrancesca added the bug Something isn't working, use only for issues label Jul 27, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-27T02:53:44.963+0000

  • Duration: 39 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 332
Skipped 0
Total 332

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.409
Classes 91.667% (11/12) 👎 -5.409
Methods 82.692% (172/208) 👎 -6.506
Lines 92.894% (2157/2322) 👍 1.87
Conditionals 100.0% (0/0) 💚
zmoog
zmoog approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM.
@paolafrancesca
Copy link
Author

paolafrancesca commented Jul 27, 2022

Good catch, LGTM.

not my catch, but I had the same reaction :D
@paolafrancesca paolafrancesca merged commit 41b29d2 into elastic:main Jul 27, 2022
@paolafrancesca paolafrancesca mentioned this pull request Jul 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

3 participants

@paolafrancesca @elasticmachine @zmoog