[AWS] Update AWS cloud.region parsing #4024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
| Relates to elastic/beats#32703 |
Contributor
| /test |
🌐 Coverage report
|
efd6 approved these changes Aug 22, 2022
kaiyan-sheng approved these changes Aug 22, 2022
| ignore_missing: true | ||
| ignore_failure: true | ||
| patterns: | ||
| - ^%{DATA}s3\.%{DATA:cloud.region}\.%{DATA}$ |
Contributor
There was a problem hiding this comment.
@legoguy1000 Should we add a check to see if aws.s3acccess.host_header exists?
Contributor Author
There was a problem hiding this comment.
Isnt that the idea of the ignore_missing??
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The AWS-S3 input sets the
cloud.regionfield to the region the S3 bucket is located. This is not always the same as the region the event originated per https://discuss.elastic.co/t/filebeat-aws-cloudtrail-processor-parses-incorrect-aws-region-from-logs/312150. The current ingest pipelines only use a rename processor which doesn't work if the field already exists. This changes the processor a set to override from the input. Also adds additional parsing for datastreams that don't already havecloud.regionset.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots