Skip to content

Conversation

@MichaelKatsoulis
Copy link
Contributor

What does this PR do?

This PR updates the index pattern used for all adHoc data views used in Kubernetes Cluster Overview dashboard.
The reason is that this index pattern does not work in cross cluster search use cases where metrics come from different sources and use different patterns.
An wider index-pattern like *metrics-* is tested to solve the issue.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@MichaelKatsoulis MichaelKatsoulis requested review from a team as code owners June 19, 2023 11:28
@MichaelKatsoulis MichaelKatsoulis requested review from tetianakravchenko and removed request for devamanv June 19, 2023 11:29
@elasticmachine
Copy link

elasticmachine commented Jun 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-19T11:29:58.929+0000

  • Duration: 32 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 96.154% (75/78) 👎 -1.763
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
Copy link
Contributor

@tetianakravchenko tetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing vis specific here, LGTM!

@MichaelKatsoulis MichaelKatsoulis merged commit d310c93 into elastic:main Jun 22, 2023
@elasticmachine
Copy link

Package kubernetes - 1.43.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

"sourceFilters": [],
"timeFieldName": "@timestamp",
"title": "metrics-*"
"title": "*metrics-*"
Copy link
Contributor

@herrBez herrBez Jul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,
I think it should be actually metrics-*,*:metrics-* otherwise you are only checking in the local cluster (not performing CCS) and you are looking for indices that starts with metics locally e.g., foometrics would also be checked (which does not really make sense).

Something similar have been used here elastic/kibana#161016

@herrBez
Copy link
Contributor

herrBez commented Jul 5, 2023

Hi there,

I think it should be actually metrics-*,*:metrics-* otherwise you are only checking in the local cluster (not performing CCS) and you are looking for indices that starts with metics locally e.g., foometrics-test would also be checked (which does not really make sense).

Something similar have been used here elastic/kibana#161016

@gizas
Copy link
Contributor

gizas commented Jul 11, 2023

Hello @herrBez , so you are saying that actually *metrics-* does not cover us in CCS scenarios.

I can confirm your saying with following tests:

Pattern: *metrics-*:

Screenshot 2023-07-11 at 3 53 00 PM

Pattern *:metrics-*

Screenshot 2023-07-11 at 3 50 11 PM

I will update acordingly

@herrBez
Copy link
Contributor

herrBez commented Jul 11, 2023

Yes, it is exactly what I am saying :) . So the right value should be metrics-*,*:metrics-*

@briandoesdev
Copy link

@gizas FYI my team implemented the K8S integration this week and started receiving errors on the "Overview" dashboard for a missing node role: "remote_cluster_client". Turns out that if your Elasticsearch nodes do not have this role the dashboards break because of the *:metrics-* value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8 participants