[Elastic Agent] Add queue depth, output batch size and rate #7611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
joshdover added the Team:Elastic-Agent joshdover changed the title 🌐 Coverage report
|
faec approved these changes Aug 30, 2023
faec left a comment
faec left a comment There was a problem hiding this comment.
Looks good except some description typos
packages/elastic_agent/data_stream/auditbeat_logs/fields/fields.yml Outdated Show resolved Hide resolved
packages/elastic_agent/data_stream/auditbeat_logs/fields/fields.yml Outdated Show resolved Hide resolved
cmacknz reviewed Aug 30, 2023
packages/elastic_agent/kibana/dashboard/elastic_agent-f47f18cc-9c7d-4278-b2ea-a6dee816d395.json Show resolved Hide resolved
cmacknz reviewed Aug 30, 2023
packages/elastic_agent/data_stream/auditbeat_logs/fields/fields.yml Outdated Show resolved Hide resolved
Contributor Author
| Thanks @faec for catching my bad copy and paste 🤦 |
joshdover changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds more in depth metrics for viewing output batches sizes, batches/sec, and input queue sizes. This helps with tuning
workersandbulk_max_sizeto avoid filling up the queues.For the input queue metrics, we currently only have this data on the
logs-elastic_agent.*beat-*data streams, rather than on themetrics-*data streams. Fixing this requires some fixes in Agent and I'd like to get value out on this sooner, so I'm deciding to map these fields for now onlogsand we'll fix later (opened elastic/elastic-agent#3334) on a future Agent version.@elastic/elastic-agent-data-plane I would like confirmation that I am interpreting this metric fields correctly.
Checklist
changelog.ymlfile.How to test this PR locally
elastic-package stack up && elastic-package build && elastic-package installGo to Fleet -> click on an Agent -> View more agent metrics
Related issues
Screenshots
Output write batches/sec
Output batch size by beat type
Queue depth by input