Skip to content

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Nov 8, 2023

Proposed commit message

Add permissions to reroute log events in all data streams in Azure Logs.

The additional permissions will allow us to:

  • Send all the log events to a single data stream (for example, the generic event hub or platform logs) and reroute them to a different one.
  • Remove the embedded Spring Apps pipeline from platform logs.

Rerouting can be set up by defining routing rules at the integration level or allowing users to add a reroute processor to the custom ingest pipeline.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
zmoog added 2 commits November 8, 2023 09:04
This will allow us to: - Send all the log events to a single data stream (for example, the generic event hub, or platform logs) and then route them to another one. - Remove the embedded Spring Apps pipeline from platform logs.
The reroute processor [^1] is available starting from stack version 8.8.0. [^1]: https://www.elastic.co/guide/en/elasticsearch/reference/master/reroute-processor.html
@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Nov 8, 2023
@zmoog zmoog self-assigned this Nov 8, 2023
@zmoog zmoog changed the title Allow rerouting in Azure Logs data streams Allow rerouting of Azure logs events to a different data stream Nov 8, 2023
@zmoog zmoog marked this pull request as ready for review November 8, 2023 08:29
@zmoog zmoog requested a review from a team as a code owner November 8, 2023 08:29
@elasticmachine
Copy link

elasticmachine commented Nov 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-08T18:22:05.229+0000

  • Duration: 16 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -8.081
Classes 86.364% (19/22) 👎 -8.081
Methods 83.333% (155/186) 👎 -6.368
Lines 85.021% (2821/3318) 👎 -1.062
Conditionals 100.0% (0/0) 💚
@zmoog
Copy link
Contributor Author

zmoog commented Nov 8, 2023

The test fails because one of the platform logs test files contains invalid JSON.

The test wasn't failing before because up to stack version 8.6, the JSON processor was tolerant of invalid documents. From 8.7, the JSON became strict by default, and now that I bumped the minimum version 8.8, it fails.

For all the gory details, check out zmoog/public-notes#54

zmoog added 2 commits November 8, 2023 19:20
With 8.7, the JSON processor became strict by default; this caused the failure of the platform logs due to an old, invalid JSON document lurking around in the test suite.
@zmoog zmoog merged commit c49b2bb into elastic:main Nov 8, 2023
@zmoog zmoog deleted the zmoog/allow-rerouting-in-azure-logs branch November 8, 2023 18:40
@elasticmachine
Copy link

Package azure - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=azure

@andrewkroh andrewkroh added the Integration:azure Azure Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:azure Azure Logs Team:Cloud-Monitoring Label for the Cloud Monitoring team

4 participants