fix: mark no-throw-statements rule as requiring type checking #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## update #963 +/- ## ========================================= Coverage ? 88.82% ========================================= Files ? 51 Lines ? 4885 Branches ? 714 ========================================= Hits ? 4339 Misses ? 534 Partials ? 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Previously, the rule `functional/no-throw-statements` did not declare `requiresTypeChecking: true`, which caused runtime errors when using it with `@typescript-eslint` without a `parserOptions.project` set. This change adds `requiresTypeChecking: true` to the rule's meta to align with its actual type-dependent behavior.
RebeccaStevens merged commit b06c25c into eslint-functional:update 14 of 15 checks passed
Merged
| 🎉 This PR is included in version 9.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously, the rule
functional/no-throw-statementsdid not declarerequiresTypeChecking: true, which caused runtime errors when using it with@typescript-eslintwithout aparserOptions.projectset.This change adds
requiresTypeChecking: trueto the rule's meta to align with its actual type-dependent behavior.