Small tweaks to SSR to match #14594 #14618
Merged
+14 −17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
threepointone approved these changes Jan 18, 2019
Collaborator Author
| Oops sorry for making conflicts with yours! |
Contributor
| all good 😘 |
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
* Small tweaks to SSR to match facebook#14594 * Remove unnecessary comparison
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
* Small tweaks to SSR to match facebook#14594 * Remove unnecessary comparison
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
* Small tweaks to SSR to match #14594 * Remove unnecessary comparison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This isn't important but it brings the SSR code closer in naming and structure to changes in #14594.