Bck 5159 nix header location #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The nix setup we use at FlightAware puts the headers in a separate location than the lib install directory. Therefore the target should reference the header install location for taget_include_directories BCK-5159
Contributor Author
| The test errors are coming from a timeout on the mac test side. I think we'll try moving over to github actions for these given the restrictions being introduced in travis. So for now I'd say we can review / merge this and we'll handle the test updates in a separate ticket. |
maryryang2 approved these changes Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
nixsetup for the cpptcl package at FlightAware installs the headers in thedevstore while libraries are in theoutstore. As such the cmake targets need to reference that dev store which is found in theCMAKE_INSTALL_INCLUDEDIRvar.