Explicitly define namespaces in headers instead of relying on include site #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… site The old way was supposedly undefined behavior according to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105707 and began causing the build to fail on GCC 12.2. Explicitly declaring the namespaces within the headers themselves fixes the build and doesn't seem like it would have unintended consequences (most of the headers are private and only included once anyway). EP-209
agbrooks approved these changes Jun 1, 2023
agbrooks left a comment
agbrooks left a comment There was a problem hiding this comment.
Thanks for figuring this out so quickly!
Contributor
| Are the Mac CI failures still of concern? |
Member Author
| I'd like to spend a little more time to see if they can be sorted |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The old way was supposedly undefined behavior according to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105707
and began causing the build to fail on GCC 12.2. Explicitly declaring
the namespaces within the headers themselves fixes the build and doesn't
seem like it would have unintended consequences (most of the headers are
private and only included once anyway).
EP-209