This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[cloud_firestore] Fix wrong FieldValue #1543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
Contributor
| Thanks for the fix @creativecreatorormaybenot. I've updated the integration test to ensure that it can catch this bug. I'd love to have a system (flutter/flutter#27258) for ensuring that changes are published promptly after merges, although it looks like in this case it was helpful to get the additional feedback. |
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* [cloud_firestore] Fix wrong FieldValue * Update integration test to catch increment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Slight mistake that occured in #1491.
As version
0.10.0has not even been rolled out to Pub yet, I do not think that I need to bump the version.Still, I am wondering why
0.10.0is still not on Pub as it has been 3 days.