Skip to content

changes needed for golang/go issue 36364 #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changes needed for golang/go issue 36364 #216

wants to merge 1 commit into from

Conversation

@brianonn
Copy link

@brianonn brianonn commented Mar 19, 2020

This PR is related to changes in issue golang/go#36364 and it's PR golang/go#37944.

This PR is only required if the PR golang/go#37944 is accepted for merge.
@brianonn brianonn mentioned this pull request Mar 19, 2020
Closed
@gopherbot
Copy link
Contributor

gopherbot commented Mar 19, 2020

This PR (HEAD: bd703d8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/224018 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Mar 23, 2020

Message from Rebecca Stambler:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 23, 2020

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1a346bda

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 23, 2020

Message from Michael Matloob:

Patch Set 1:

Hello, I'll wait for the golang.org/cl/224017 to be merged before reviewing this. Please respond to this change once that's done and I'll take a look.

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 23, 2020

Message from Gobot Gobot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Oct 6, 2020

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b22d2331-8b34-44b6-924c-10914757635f

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Oct 6, 2020

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/b22d2331-8b34-44b6-924c-10914757635f

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Oct 15, 2020

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1a346bda

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Oct 15, 2020

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=1a346bda

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Michael Matloob:

Patch Set 1:

Hello, I'll wait for the golang.org/cl/224017 to be merged before reviewing this. Please respond to this change once that's done and I'll take a look.

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b22d2331-8b34-44b6-924c-10914757635f

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/b22d2331-8b34-44b6-924c-10914757635f

Please don’t reply on this GitHub thread. Visit golang.org/cl/224018.
After addressing review feedback, remember to publish your drafts!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes

3 participants

@brianonn @gopherbot @googlebot