Skip to content

present: properly render sub-section heading #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

present: properly render sub-section heading #238

wants to merge 2 commits into from
+13 −8

Conversation

@FilipNikolovski
Copy link

@FilipNikolovski FilipNikolovski commented Jun 25, 2020 •
edited
Loading

This fixes: golang/go#6846

If we take the example from the readme:

# Title of Talk My Name 9 Mar 2020 me@example.com ## Title of Slide or Section (must begin with ##) Some Text ### Subsection {#anchor} - bullets - more bullets - a bullet continued on the next line #### Sub-subsection Some More text

The sub-section and sub-subsection will have the headings <h2> and <h3> respectively,
which breaks the page, since the main title has a heading of <h3> so it pushes down the sub-section to
the bottom of the page.

If we use .Level for the section heading, they will have the headings <h3> and <h4> which will render properly.
@FilipNikolovski
present: properly render section heading using the section's level nu…
b56102b 
…mber This fixes golang/go#6846 If we take the example from the readme: Some Text - bullets - more bullets - a bullet continued on the next line Some More text	Preformatted text (code block)	is indented (by one tab, or four spaces) The sub-section and sub-subsection will have the headings <h2> and <h3> respectively, which breaks the page, since the main title has a heading of <h3> so it pushes down the sub-section to the bottom of the page. If we use .Level for the section heading, they will have the headings <h3> and <h4> which will render properly.
@gopherbot
Copy link
Contributor

gopherbot commented Jun 25, 2020

This PR (HEAD: b56102b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/240018 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Jun 25, 2020

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Aug 7, 2020

Message from Robert Findley:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Sep 8, 2020

Message from Gorka Lerchundi Osa:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Sep 10, 2020

Message from Russ Cox:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Sep 10, 2020

Message from Russ Cox:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Sep 10, 2020

Message from Russ Cox:

Patch Set 3: Published edit on patch set 2.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Sep 10, 2020

Message from Russ Cox:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Sep 10, 2020

Message from Filip Nikolovski:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@FilipNikolovski
present: new css class for the heading title for slide articles
91ef97b 
The .title class is used in case the title is the only thing being rendered in an article. The position: absolute property was previously set on the h2 element, which broke the article's contents. Now the slide's articles will begin from h2 instead of h3, and will be properly positioned.
@gopherbot
Copy link
Contributor

gopherbot commented Sep 13, 2020

This PR (HEAD: 91ef97b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/240018 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Sep 13, 2020

Message from Filip Nikolovski:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Oct 15, 2020

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Gorka Lerchundi Osa:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Russ Cox:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Russ Cox:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Russ Cox:

Patch Set 3: Published edit on patch set 2.

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Russ Cox:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Filip Nikolovski:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Filip Nikolovski:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/240018.
After addressing review feedback, remember to publish your drafts!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes

3 participants

@FilipNikolovski @gopherbot @googlebot