Skip to content

present: add support for full screen mode #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

present: add support for full screen mode #31

wants to merge 1 commit into from
+20 −4

Conversation

@lucor
Copy link

@lucor lucor commented Mar 21, 2018 •
edited
Loading

This pull request add the -fullscreen flag to enable full screen mode (default: false).
When enabled all the slides except the current one are hidden.

Fixes golang/go#12634
Fixes golang/go#18299
@lucor
tools/present: add support for full screen mode
1c65b8c 
This commit add the -fullscreen flag to enable full screen mode (default: false). When enabled all the slides except the current one are hidden. Fixes golang/go#12634 and golang/go#18299 Change-Id: Id2237aa938bdc7478e2072817e7abf2b7865dea8
@gopherbot
Copy link
Contributor

gopherbot commented Mar 21, 2018

This PR (HEAD: 1c65b8c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/tools/+/101956 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Mar 21, 2018

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 21, 2018

Message from Tobias Klauser:

Patch Set 2:

(3 comments)

Thanks. Please see a few comments regarding the commit message format.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@lucor lucor changed the title tools/present: add support for full screen mode present: add support for full screen mode Mar 21, 2018
@gopherbot
Copy link
Contributor

gopherbot commented Mar 21, 2018

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 21, 2018

Message from Luca Corbo:

Patch Set 3:

(3 comments)

I've updated the commit message format.
Thanks for your feedback.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 21, 2018

Message from Tobias Klauser:

Patch Set 3: Code-Review+1

(1 comment)

One small nit, otherwise LGTM.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 22, 2018

Message from Luca Corbo:

Patch Set 3:

(1 comment)

Patch Set 3: Code-Review+1

(1 comment)

One small nit, otherwise LGTM.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Mar 28, 2018

Message from Tobias Klauser:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@fabriziomoscon fabriziomoscon mentioned this pull request Sep 21, 2018
Open
@ebenoist
Copy link

ebenoist commented Sep 11, 2019

This would be super useful, can this be merged?
@gopherbot gopherbot force-pushed the master branch 3 times, most recently from 88641d9 to db1ebf7 Compare October 4, 2019 03:45
@gopherbot gopherbot force-pushed the master branch 14 times, most recently from 8185551 to dc03839 Compare November 5, 2019 20:21
WenzheLiu pushed a commit to WenzheLiu/tools that referenced this pull request Nov 29, 2019
Merge pull request golang#31 in ~WELIU/gotools from search-page to dev
e4d3e92 
* commit '1aec439977e8d7bd0d7927896da11a720aa3401c': move front ppt search app (cannot embedded into present, because vue should use static '/' but is already used by dirHandler finish web page of search ppt search page vue project setup: copy from atlas
@jonaz
Copy link

jonaz commented Sep 7, 2020

Whats holding this back? Would be nice to not have to zoom the browser every time i do a presentation...
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Gerrit User 19560:

Patch Set 2:

(3 comments)

Thanks. Please see a few comments regarding the commit message format.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Gerrit User 26935:

Patch Set 3:

(3 comments)

I've updated the commit message format.
Thanks for your feedback.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Gerrit User 19560:

Patch Set 3: Code-Review+1

(1 comment)

One small nit, otherwise LGTM.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Gerrit User 26935:

Patch Set 3:

(1 comment)

Patch Set 3: Code-Review+1

(1 comment)

One small nit, otherwise LGTM.

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 8, 2021

Message from Gerrit User 19560:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/101956.
After addressing review feedback, remember to publish your drafts!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes

5 participants

@lucor @gopherbot @ebenoist @jonaz @googlebot