Skip to content

Conversation

@lsirac
Copy link
Contributor

@lsirac lsirac commented Jul 28, 2022

For successful responses, the expiration_time field is only required
when an output file is specified in the credential configuration.

@lsirac lsirac requested review from a team as code owners July 28, 2022 23:17
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jul 28, 2022
…n output file is specified in the credential configuration
@lsirac lsirac force-pushed the expiration_time branch from f367360 to 5582fe1 Compare July 28, 2022 23:18
@lsirac lsirac requested a review from TimurSadykov July 28, 2022 23:23
@lsirac lsirac added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 3, 2022
@lsirac lsirac requested a review from clundin25 August 4, 2022 18:08
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review in progress

Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsirac lsirac merged commit 48ff83d into main Aug 5, 2022
@lsirac lsirac deleted the expiration_time branch August 5, 2022 17:47
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ## [1.10.0](v1.9.0...v1.10.0) (2022-08-05) ### Features * workforce identity federation for pluggable auth ([#959](#959)) ([7f2c535](7f2c535)) ### Bug Fixes * updates executable response spec for executable-sourced credentials ([#955](#955)) ([48ff83d](48ff83d)) ### Documentation * **samples:** added auth samples and tests ([#927](#927)) ([32c717f](32c717f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
TimurSadykov pushed a commit that referenced this pull request Aug 10, 2022
🤖 I have created a release *beep* *boop* --- ## [1.10.0](v1.9.0...v1.10.0) (2022-08-05) ### Features * workforce identity federation for pluggable auth ([#959](#959)) ([7f2c535](7f2c535)) ### Bug Fixes * updates executable response spec for executable-sourced credentials ([#955](#955)) ([48ff83d](48ff83d)) ### Documentation * **samples:** added auth samples and tests ([#927](#927)) ([32c717f](32c717f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

4 participants