Skip to content

fix: make some enum fields final #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix: make some enum fields final #1526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c11b728
Make some enum fields final
cushon Oct 3, 2024
b9ca65c
One more field
cushon Oct 3, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion credentials/java/com/google/auth/CredentialTypeForMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public enum CredentialTypeForMetrics {
IMPERSONATED_CREDENTIALS("imp"),
DO_NOT_SEND("dns");

private String label;
private final String label;

private CredentialTypeForMetrics(String label) {
this.label = label;
Expand Down
2 changes: 1 addition & 1 deletion oauth2_http/java/com/google/auth/oauth2/IdTokenProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public enum Option {
LICENSES_TRUE("licensesTrue"),
INCLUDE_EMAIL("includeEmail");

private String option;
private final String option;

private Option(String option) {
this.option = option;
Expand Down
2 changes: 1 addition & 1 deletion oauth2_http/java/com/google/auth/oauth2/MetricsUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public enum RequestType {
METADATA_SERVER_PING("mds"),
UNTRACKED("untracked");

private String label;
private final String label;

private RequestType(String label) {
this.label = label;
Expand Down