feat: DataQualityDimension is now part of the DataQualityDimensionResult message (#11791)

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 571976684 Source-Link: googleapis/googleapis@38d8c5d Source-Link: googleapis/googleapis-gen@2132f5e Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRhdGFwbGV4Ly5Pd2xCb3QueWFtbCIsImgiOiIyMTMyZjVlMWE0NGI2OTNjNzRiM2NlNTNiMDNlZDRmNjcyMWJjMWRhIn0= --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Author: gcf-owl-bot[bot]

packages/google-cloud-dataplex/CONTRIBUTING.rst

@@ -143,12 +143,12 @@ Running System Tests
  $ nox -s system
 
  # Run a single system test
- $ nox -s system- -- -k <name of test>
+ $ nox -s system-3.11 -- -k <name of test>
 
 
  .. note::
 
- System tests are only configured to run under Python.
+ System tests are only configured to run under Python 3.8, 3.9, 3.10 and 3.11.
  For expediency, we do not run them in older versions of Python 3.
 
  This alone will not run the tests. You'll need to change some local

packages/google-cloud-dataplex/google/cloud/dataplex/__init__.py

@@ -62,6 +62,7 @@
  DataProfileSpec,
 )
 from google.cloud.dataplex_v1.types.data_quality import (
+ DataQualityDimension,
  DataQualityDimensionResult,
  DataQualityResult,
  DataQualityRule,
@@ -212,6 +213,7 @@
  "UpdateContentRequest",
  "DataProfileResult",
  "DataProfileSpec",
+ "DataQualityDimension",
  "DataQualityDimensionResult",
  "DataQualityResult",
  "DataQualityRule",

packages/google-cloud-dataplex/google/cloud/dataplex/gapic_version.py

@@ -13,4 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-__version__ = "1.6.3" # {x-release-please-version}
+__version__ = "0.0.0" # {x-release-please-version}

packages/google-cloud-dataplex/google/cloud/dataplex_v1/__init__.py

@@ -40,6 +40,7 @@
 )
 from .types.data_profile import DataProfileResult, DataProfileSpec
 from .types.data_quality import (
+ DataQualityDimension,
  DataQualityDimensionResult,
  DataQualityResult,
  DataQualityRule,
@@ -190,6 +191,7 @@
  "DataAttributeBinding",
  "DataProfileResult",
  "DataProfileSpec",
+ "DataQualityDimension",
  "DataQualityDimensionResult",
  "DataQualityResult",
  "DataQualityRule",

packages/google-cloud-dataplex/google/cloud/dataplex_v1/gapic_version.py

@@ -13,4 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-__version__ = "1.6.3" # {x-release-please-version}
+__version__ = "0.0.0" # {x-release-please-version}

packages/google-cloud-dataplex/google/cloud/dataplex_v1/types/__init__.py

@@ -24,6 +24,7 @@
 )
 from .data_profile import DataProfileResult, DataProfileSpec
 from .data_quality import (
+ DataQualityDimension,
  DataQualityDimensionResult,
  DataQualityResult,
  DataQualityRule,
@@ -157,6 +158,7 @@
  "UpdateContentRequest",
  "DataProfileResult",
  "DataProfileSpec",
+ "DataQualityDimension",
  "DataQualityDimensionResult",
  "DataQualityResult",
  "DataQualityRule",

packages/google-cloud-dataplex/google/cloud/dataplex_v1/types/data_quality.py

@@ -28,6 +28,7 @@
  "DataQualityResult",
  "DataQualityRuleResult",
  "DataQualityDimensionResult",
+ "DataQualityDimension",
  "DataQualityRule",
  },
 )
@@ -295,16 +296,41 @@ class DataQualityDimensionResult(proto.Message):
  per-dimension view of the results.
 
  Attributes:
+ dimension (google.cloud.dataplex_v1.types.DataQualityDimension):
+ Output only. The dimension config specified
+ in the DataQualitySpec, as is.
  passed (bool):
  Whether the dimension passed or failed.
  """
 
+ dimension: "DataQualityDimension" = proto.Field(
+ proto.MESSAGE,
+ number=1,
+ message="DataQualityDimension",
+ )
  passed: bool = proto.Field(
  proto.BOOL,
  number=3,
  )
 
 
+class DataQualityDimension(proto.Message):
+ r"""A dimension captures data quality intent about a defined
+ subset of the rules specified.
+
+ Attributes:
+ name (str):
+ The dimension name a rule belongs to. Supported dimensions
+ are ["COMPLETENESS", "ACCURACY", "CONSISTENCY", "VALIDITY",
+ "UNIQUENESS", "INTEGRITY"]
+ """
+
+ name: str = proto.Field(
+ proto.STRING,
+ number=1,
+ )
+
+
 class DataQualityRule(proto.Message):
  r"""A rule captures data quality intent about a data source.
 

packages/google-cloud-dataplex/noxfile.py

@@ -46,7 +46,7 @@
 UNIT_TEST_EXTRAS = []
 UNIT_TEST_EXTRAS_BY_PYTHON = {}
 
-SYSTEM_TEST_PYTHON_VERSIONS = []
+SYSTEM_TEST_PYTHON_VERSIONS = ["3.8", "3.9", "3.10", "3.11"]
 SYSTEM_TEST_STANDARD_DEPENDENCIES = [
  "mock",
  "pytest",
@@ -405,24 +405,3 @@ def prerelease_deps(session):
  session.run("python", "-c", "import google.auth; print(google.auth.__version__)")
 
  session.run("py.test", "tests/unit")
-
- system_test_path = os.path.join("tests", "system.py")
- system_test_folder_path = os.path.join("tests", "system")
-
- # Only run system tests if found.
- if os.path.exists(system_test_path):
- session.run(
- "py.test",
- "--verbose",
- f"--junitxml=system_{session.python}_sponge_log.xml",
- system_test_path,
- *session.posargs,
- )
- if os.path.exists(system_test_folder_path):
- session.run(
- "py.test",
- "--verbose",
- f"--junitxml=system_{session.python}_sponge_log.xml",
- system_test_folder_path,
- *session.posargs,
- )

packages/google-cloud-dataplex/samples/generated_samples/snippet_metadata_google.cloud.dataplex.v1.json

@@ -8,7 +8,7 @@
  ],
  "language": "PYTHON",
  "name": "google-cloud-dataplex",
- "version": "1.6.3"
+ "version": "0.1.0"
  },
  "snippets": [
  {