Skip to content
This repository was archived by the owner on Jan 22, 2024. It is now read-only.

Conversation

@ikuleshov
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@ikuleshov ikuleshov requested a review from a team October 15, 2020 07:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #53 into master will increase coverage by 2.89%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #53 +/- ## ============================================ + Coverage 69.62% 72.52% +2.89%  - Complexity 40 44 +4  ============================================ Files 6 6 Lines 270 313 +43 Branches 1 1 ============================================ + Hits 188 227 +39  - Misses 81 85 +4  Partials 1 1 
Impacted Files Coverage Δ Complexity Δ
...tics/data/v1alpha/stub/AlphaAnalyticsDataStub.java 16.66% <0.00%> (-3.34%) 1.00% <0.00%> (ø%)
...ytics/data/v1alpha/AlphaAnalyticsDataSettings.java 18.91% <0.00%> (-1.09%) 2.00% <0.00%> (ø%)
.../data/v1alpha/stub/GrpcAlphaAnalyticsDataStub.java 91.17% <0.00%> (+1.64%) 12.00% <0.00%> (+1.00%)
...a/v1alpha/stub/AlphaAnalyticsDataStubSettings.java 83.59% <0.00%> (+2.46%) 14.00% <0.00%> (+1.00%)
...alytics/data/v1alpha/AlphaAnalyticsDataClient.java 53.12% <0.00%> (+3.12%) 13.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8ff79...10ce390. Read the comment docs.

@product-auto-label product-auto-label bot added api: docs Issues related to the Docs API API. samples Issues that are directly related to samples. labels Oct 15, 2020
Copy link

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please follow the sample format guidelines.
  2. Please save and restore System.out
@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: docs Issues related to the Docs API API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

3 participants