fix: reset send timestamp each time a request is sent #2499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s 
yirutang reviewed May 11, 2024
...oud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java Show resolved Hide resolved
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java Show resolved Hide resolved
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java Show resolved Hide resolved
agrawal-siddharth force-pushed the resetSendTime branch from 733917c to d00fc48 Compare yirutang approved these changes May 13, 2024
...oud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java Show resolved Hide resolved
Each time a request is removed from the inflight queue its send timestamp should be removed by setting it to null as we are no longer waiting for a response to arrive for it.
agrawal-siddharth force-pushed the resetSendTime branch from d00fc48 to cb7d3e2 Compare product-auto-label bot added size: m agrawal-siddharth added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run agrawal-siddharth added kokoro:force-run 
gcf-owl-bot bot removed the owlbot:run 
gcf-merge-on-green bot pushed a commit that referenced this pull request May 24, 2024
🤖 I have created a release *beep* *boop* --- ## [3.5.2](https://togithub.com/googleapis/java-bigquerystorage/compare/v3.5.1...v3.5.2) (2024-05-24) ### Bug Fixes * Reset send timestamp each time a request is sent ([#2499](https://togithub.com/googleapis/java-bigquerystorage/issues/2499)) ([b1b62b1](https://togithub.com/googleapis/java-bigquerystorage/commit/b1b62b1a8b89e8b5b950e0f5e35f385c35bae2da)) ### Dependencies * Update actions/checkout digest to 0ad4b8f ([#2496](https://togithub.com/googleapis/java-bigquerystorage/issues/2496)) ([22e8f62](https://togithub.com/googleapis/java-bigquerystorage/commit/22e8f62940cedfa051b77383773324bbcc79bb95)) * Update actions/checkout digest to 44c2b7a ([#2494](https://togithub.com/googleapis/java-bigquerystorage/issues/2494)) ([87b435a](https://togithub.com/googleapis/java-bigquerystorage/commit/87b435a5add55ba7f0cad52c59df5c67bc0dfb70)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.40.0 ([#2488](https://togithub.com/googleapis/java-bigquerystorage/issues/2488)) ([85f7f05](https://togithub.com/googleapis/java-bigquerystorage/commit/85f7f05a249b9be3ab29bff0e4bba26032543423)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.40.1 ([#2492](https://togithub.com/googleapis/java-bigquerystorage/issues/2492)) ([f6c6f02](https://togithub.com/googleapis/java-bigquerystorage/commit/f6c6f027d63d0d3d74d7791affd98e7ee359aabc)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.30.1 ([#2502](https://togithub.com/googleapis/java-bigquerystorage/issues/2502)) ([ed4d1a3](https://togithub.com/googleapis/java-bigquerystorage/commit/ed4d1a38adee35450b73aefa21e25d13e8bf8469)) * Update dependency com.google.http-client:google-http-client to v1.44.2 ([#2503](https://togithub.com/googleapis/java-bigquerystorage/issues/2503)) ([66840e6](https://togithub.com/googleapis/java-bigquerystorage/commit/66840e6acd832702157d434762eef66e00c4c5df)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.2 ([#2504](https://togithub.com/googleapis/java-bigquerystorage/issues/2504)) ([bebbd21](https://togithub.com/googleapis/java-bigquerystorage/commit/bebbd218623554bae32eeeda81e3c9f166d31b93)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Each time a request is removed from the inflight queue its send timestamp should be removed by setting it to null as we are no longer waiting for a response to arrive for it.