fix: BQTableSchemaToProtobufDescriptor will now only generate lower-cased fieldnames in the protobuf descriptor #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
allenc3 force-pushed the FixBQToProto branch 2 times, most recently from 727c354 to 27166c4 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #415 +/- ## ============================================ + Coverage 76.83% 77.30% +0.47% - Complexity 564 574 +10 ============================================ Files 55 55 Lines 3328 3367 +39 Branches 201 198 -3 ============================================ + Hits 2557 2603 +46 + Misses 661 660 -1 + Partials 110 104 -6
Continue to review full report at Codecov.
|
yirutang approved these changes Jul 15, 2020
...test/java/com/google/cloud/bigquery/storage/v1alpha2/BQTableSchemaToProtoDescriptorTest.java Outdated Show resolved Hide resolved
allenc3 changed the title 
stephaniewang526 approved these changes Jul 15, 2020
stephaniewang526 added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run stephaniewang526 added kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
| Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
stephaniewang526 removed the automerge stephaniewang526 added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.1.1...v1.2.0) (2020-07-16) ### Features * add 'Received Rst Stream' to automatic retry strings ([#419](https://www.github.com/googleapis/java-bigquerystorage/issues/419)) ([1584bdb](https://www.github.com/googleapis/java-bigquerystorage/commit/1584bdbf5820a378d844d333e8546b6a26b3c643)) ### Bug Fixes * BQTableSchemaToProtobufDescriptor will now only generate lower-cased fieldnames in the protobuf descriptor ([#415](https://www.github.com/googleapis/java-bigquerystorage/issues/415)) ([4672939](https://www.github.com/googleapis/java-bigquerystorage/commit/46729398eee0f728c3de731f803580342fbe787f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since the backend is case-insensitive, letting all fieldnames be lowercased in the generated protobuf descriptor can save some space/time while using the generated descriptor to create a protobuf message from JSON.