Skip to content

Conversation

@jainsahab
Copy link
Contributor

@jainsahab jainsahab commented May 24, 2023

Documenting the thread unsafe behaviour of Transaction, Batch and DatastoreBatchWriter classes.

Fixes #295

@jainsahab jainsahab requested review from a team as code owners May 24, 2023 08:37
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels May 24, 2023
@jainsahab jainsahab changed the title docs: Marking Transaction, Batch and DatastoreBatchWriter class with 'NotThreadSafe annotation docs: Marking Transaction, Batch and DatastoreBatchWriter class with 'NotThreadSafe' annotation May 24, 2023
@jainsahab jainsahab requested a review from a team as a code owner May 24, 2023 10:22
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with two small nits

@jainsahab jainsahab added the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@jainsahab jainsahab merged commit 9e96650 into googleapis:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.

2 participants