Skip to content

Commit 2a4a7b5

Browse files
author
Brian Chen
authored
fix: catch null Firestore in system tests (#215)
1 parent b376003 commit 2a4a7b5

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryWatchTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
import com.google.common.base.Joiner;
4040
import com.google.common.base.Joiner.MapJoiner;
4141
import com.google.common.base.Optional;
42+
import com.google.common.base.Preconditions;
4243
import com.google.common.base.Predicate;
4344
import com.google.common.collect.FluentIterable;
4445
import com.google.common.collect.Range;
@@ -83,6 +84,9 @@ public void before() {
8384

8485
@AfterClass
8586
public static void afterClass() throws Exception {
87+
Preconditions.checkNotNull(
88+
firestore,
89+
"Error instantiating Firestore. Check that the service account credentials were properly set.");
8690
firestore.close();
8791
}
8892

google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@
5555
import com.google.cloud.firestore.Transaction.Function;
5656
import com.google.cloud.firestore.WriteBatch;
5757
import com.google.cloud.firestore.WriteResult;
58+
import com.google.common.base.Preconditions;
5859
import com.google.common.collect.ImmutableList;
5960
import com.google.common.collect.ImmutableMap;
6061
import java.util.ArrayList;
@@ -104,6 +105,9 @@ public void before() {
104105

105106
@After
106107
public void after() throws Exception {
108+
Preconditions.checkNotNull(
109+
firestore,
110+
"Error instantiating Firestore. Check that the service account credentials were properly set.");
107111
firestore.close();
108112
}
109113

0 commit comments

Comments
 (0)