Skip to content

Commit 92224bc

Browse files
yoshi-automationBenWhitehead
yoshi-automation
and
BenWhitehead
authored
chore!: enable gapicv2 (#188)
* chore!: enable gapicv2 for firestore/v1beta1 API Committer: @miraleung PiperOrigin-RevId: 305537104 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Apr 8 12:58:48 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 6f8350c0df231d7e742fa10dbf929f33047715c9 Source-Link: googleapis/googleapis@6f8350c * chore!: enable gapicv2 for firestore/admin/v1 API Committer: @miraleung There are the following breaking changes due to the collection_id discrepancy between [1] and [2] 1. https://github.com/googleapis/googleapis/blob/6f8350c0df231d7e742fa10dbf929f33047715c9/google/firestore/admin/v1/firestore_gapic.yaml#L24-L29 2. https://github.com/googleapis/googleapis/blob/6f8350c0df231d7e742fa10dbf929f33047715c9/google/firestore/admin/v1/field.proto#L39 ``` com.google.firestore.admin.v1.FieldName: Method 'public java.lang.String getCollectionId()' has been removed com.google.firestore.admin.v1.FieldName: Method 'public java.lang.String getFieldId()' has been removed com.google.firestore.admin.v1.FieldName$Builder: Method 'public java.lang.String getCollectionId()' has been removed com.google.firestore.admin.v1.FieldName$Builder: Method 'public java.lang.String getFieldId()' has been removed com.google.firestore.admin.v1.FieldName$Builder: Method 'public com.google.firestore.admin.v1.FieldName$Builder setCollectionId(java.lang.String)' has been removed com.google.firestore.admin.v1.FieldName$Builder: Method 'public com.google.firestore.admin.v1.FieldName$Builder setFieldId(java.lang.String)' has been removed com.google.firestore.admin.v1.IndexName: Method 'public java.lang.String getCollectionId()' has been removed com.google.firestore.admin.v1.IndexName: Method 'public java.lang.String getIndexId()' has been removed com.google.firestore.admin.v1.IndexName$Builder: Method 'public java.lang.String getCollectionId()' has been removed com.google.firestore.admin.v1.IndexName$Builder: Method 'public java.lang.String getIndexId()' has been removed com.google.firestore.admin.v1.IndexName$Builder: Method 'public com.google.firestore.admin.v1.IndexName$Builder setCollectionId(java.lang.String)' has been removed com.google.firestore.admin.v1.IndexName$Builder: Method 'public com.google.firestore.admin.v1.IndexName$Builder setIndexId(java.lang.String)' has been removed ``` PiperOrigin-RevId: 305561114 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Apr 8 14:57:39 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 0d69cddaa23b556e7299f84ad55a02ec1cad55a9 Source-Link: googleapis/googleapis@0d69cdd * chore!: enable gapicv2 for firestore/v1 API Note that this contains breaking Java changes: com.google.cloud.firestore.v1.FirestoreClient: Method 'public void deleteDocument(com.google.firestore.v1.AnyPathName)' has been removed Committer: @miraleung PiperOrigin-RevId: 305561906 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Apr 8 15:01:42 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: d741cd976975c745d0199987aff0e908b8352992 Source-Link: googleapis/googleapis@d741cd9 * chore!: add clirr-ignored-differences.xml BREAKING CHANGE: various renames due to generator changes Renamed data model properties * Usage of collectionId replaced with collection * Usage of fieldId replaced with field * Usage of indexId replaced with index * Usage of ParentName replaced with CollectionGroupName * Usage of AnyPathName replaced with String Long running operation renames: * FirestoreAdminClient#createIndex -> FirestoreAdminClient#createIndexAsync * FirestoreAdminClient#exportDocuments -> FirestoreAdminClient#exportDocumentsAsync * FirestoreAdminClient#importDocuments -> FirestoreAdminClient#importDocumentsAsync * FirestoreAdminClient#updateField -> FirestoreAdminClient#updateFieldAsync Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
1 parent 13edb36 commit 92224bc

22 files changed

+2989
-2162
lines changed

‎google-cloud-firestore/clirr-ignored-differences.xml‎

Lines changed: 98 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,102 @@
3636
<method>*(com.google.cloud.firestore.FirestoreImpl, *)</method>
3737
</difference>
3838

39+
<!--
40+
createIndex -> createIndexAsync
41+
-->
42+
<difference>
43+
<differenceType>7002</differenceType>
44+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
45+
<method>com.google.longrunning.Operation createIndex(com.google.firestore.admin.v1.ParentName, com.google.firestore.admin.v1.Index)</method>
46+
</difference>
47+
<difference>
48+
<differenceType>7002</differenceType>
49+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
50+
<method>com.google.longrunning.Operation createIndex(java.lang.String, com.google.firestore.admin.v1.Index)</method>
51+
</difference>
52+
<difference>
53+
<differenceType>7002</differenceType>
54+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
55+
<method>com.google.longrunning.Operation createIndex(com.google.firestore.admin.v1.CreateIndexRequest)</method>
56+
</difference>
57+
58+
<!--
59+
exportDocuments -> exportDocumentsAsync
60+
-->
61+
<difference>
62+
<differenceType>7002</differenceType>
63+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
64+
<method>com.google.longrunning.Operation exportDocuments(com.google.firestore.admin.v1.DatabaseName)</method>
65+
</difference>
66+
<difference>
67+
<differenceType>7002</differenceType>
68+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
69+
<method>com.google.longrunning.Operation exportDocuments(java.lang.String)</method>
70+
</difference>
71+
<difference>
72+
<differenceType>7002</differenceType>
73+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
74+
<method>com.google.longrunning.Operation exportDocuments(com.google.firestore.admin.v1.ExportDocumentsRequest)</method>
75+
</difference>
76+
<!--
77+
importDocuments -> importDocumentsAsync
78+
-->
79+
<difference>
80+
<differenceType>7002</differenceType>
81+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
82+
<method>com.google.longrunning.Operation importDocuments(com.google.firestore.admin.v1.DatabaseName)</method>
83+
</difference>
84+
<difference>
85+
<differenceType>7002</differenceType>
86+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
87+
<method>com.google.longrunning.Operation importDocuments(java.lang.String)</method>
88+
</difference>
89+
<difference>
90+
<differenceType>7002</differenceType>
91+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
92+
<method>com.google.longrunning.Operation importDocuments(com.google.firestore.admin.v1.ImportDocumentsRequest)</method>
93+
</difference>
94+
<!--
95+
updatedField -> updateFieldAsync
96+
-->
97+
<difference>
98+
<differenceType>7002</differenceType>
99+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
100+
<method>com.google.longrunning.Operation updateField(com.google.firestore.admin.v1.Field)</method>
101+
</difference>
102+
<difference>
103+
<differenceType>7002</differenceType>
104+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
105+
<method>com.google.longrunning.Operation updateField(com.google.firestore.admin.v1.UpdateFieldRequest)</method>
106+
</difference>
107+
<difference>
108+
<differenceType>7002</differenceType>
109+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient</className>
110+
<method>com.google.longrunning.Operation updateField(com.google.firestore.admin.v1.UpdateFieldRequest)</method>
111+
</difference>
112+
113+
<!--
114+
deleteDocument(AnyPathName) -> deleteDocument(String)
115+
-->
116+
<difference>
117+
<differenceType>7002</differenceType>
118+
<className>com/google/cloud/firestore/v1/FirestoreClient</className>
119+
<method>void deleteDocument(com.google.firestore.v1.AnyPathName)</method>
120+
</difference>
121+
<difference>
122+
<differenceType>7002</differenceType>
123+
<className>com/google/cloud/firestore/v1beta1/FirestoreClient</className>
124+
<method>void deleteDocument(com.google.firestore.v1beta1.AnyPathName)</method>
125+
</difference>
126+
127+
<!--
128+
ParentName -> CollectionGroupName
129+
-->
130+
<difference>
131+
<differenceType>7005</differenceType>
132+
<className>com/google/cloud/firestore/v1/FirestoreAdminClient*</className>
133+
<method>com.google.cloud.firestore.v1.FirestoreAdminClient$List*PagedResponse list*(com.google.firestore.admin.v1.ParentName)</method>
134+
<to>com.google.cloud.firestore.v1.FirestoreAdminClient$List*PagedResponse list*(com.google.firestore.admin.v1.CollectionGroupName)</to>
135+
</difference>
136+
39137
</differences>

0 commit comments

Comments
 (0)