Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Commit 080c590

Browse files
gcf-owl-bot[bot]Sita04
gcf-owl-bot[bot]
and
Sita04
authored
feat: Added contacts field to findings attributes, specifying Essential Contacts defined at org, folder or project level within a GCP org (#865)
* feat: Added contacts field to findings attributes, specifying Essential Contacts defined at org, folder or project level within a GCP org feat: Added process signature fields to the indicator attribute that helps surface multiple types of signature defined IOCs PiperOrigin-RevId: 458537238 Source-Link: googleapis/googleapis@7fdec62 Source-Link: https://github.com/googleapis/googleapis-gen/commit/bb340e3223539a792a204be2a794fb2ad3724f68 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmIzNDBlMzIyMzUzOWE3OTJhMjA0YmUyYTc5NGZiMmFkMzcyNGY2OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add scc-secrets, excluded samples.cfg from owlbot changes and fixed PrintStream init in Mute config test * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
1 parent 1a3e969 commit 080c590

File tree

26 files changed

+8101
-238
lines changed

26 files changed

+8101
-238
lines changed

‎.kokoro/presubmit/samples.cfg‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,5 @@ env_vars: {
2929

3030
env_vars: {
3131
key: "SECRET_MANAGER_KEYS"
32-
value: "java-docs-samples-service-account"
32+
value: "java-docs-samples-service-account,java-scc-samples-secrets"
3333
}

‎google-cloud-securitycenter/src/test/java/com/google/cloud/securitycenter/v1/SecurityCenterClientHttpJsonTest.java‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,7 @@ public void createFindingTest() throws Exception {
314314
.addAllConnections(new ArrayList<Connection>())
315315
.setMuteInitiator("muteInitiator1395645462")
316316
.addAllProcesses(new ArrayList<Process>())
317+
.putAllContacts(new HashMap<String, ContactDetails>())
317318
.addAllCompliances(new ArrayList<Compliance>())
318319
.setDescription("description-1724546052")
319320
.setExfiltration(Exfiltration.newBuilder().build())
@@ -388,6 +389,7 @@ public void createFindingTest2() throws Exception {
388389
.addAllConnections(new ArrayList<Connection>())
389390
.setMuteInitiator("muteInitiator1395645462")
390391
.addAllProcesses(new ArrayList<Process>())
392+
.putAllContacts(new HashMap<String, ContactDetails>())
391393
.addAllCompliances(new ArrayList<Compliance>())
392394
.setDescription("description-1724546052")
393395
.setExfiltration(Exfiltration.newBuilder().build())
@@ -2775,6 +2777,7 @@ public void setFindingStateTest() throws Exception {
27752777
.addAllConnections(new ArrayList<Connection>())
27762778
.setMuteInitiator("muteInitiator1395645462")
27772779
.addAllProcesses(new ArrayList<Process>())
2780+
.putAllContacts(new HashMap<String, ContactDetails>())
27782781
.addAllCompliances(new ArrayList<Compliance>())
27792782
.setDescription("description-1724546052")
27802783
.setExfiltration(Exfiltration.newBuilder().build())
@@ -2851,6 +2854,7 @@ public void setFindingStateTest2() throws Exception {
28512854
.addAllConnections(new ArrayList<Connection>())
28522855
.setMuteInitiator("muteInitiator1395645462")
28532856
.addAllProcesses(new ArrayList<Process>())
2857+
.putAllContacts(new HashMap<String, ContactDetails>())
28542858
.addAllCompliances(new ArrayList<Compliance>())
28552859
.setDescription("description-1724546052")
28562860
.setExfiltration(Exfiltration.newBuilder().build())
@@ -2925,6 +2929,7 @@ public void setMuteTest() throws Exception {
29252929
.addAllConnections(new ArrayList<Connection>())
29262930
.setMuteInitiator("muteInitiator1395645462")
29272931
.addAllProcesses(new ArrayList<Process>())
2932+
.putAllContacts(new HashMap<String, ContactDetails>())
29282933
.addAllCompliances(new ArrayList<Compliance>())
29292934
.setDescription("description-1724546052")
29302935
.setExfiltration(Exfiltration.newBuilder().build())
@@ -2999,6 +3004,7 @@ public void setMuteTest2() throws Exception {
29993004
.addAllConnections(new ArrayList<Connection>())
30003005
.setMuteInitiator("muteInitiator1395645462")
30013006
.addAllProcesses(new ArrayList<Process>())
3007+
.putAllContacts(new HashMap<String, ContactDetails>())
30023008
.addAllCompliances(new ArrayList<Compliance>())
30033009
.setDescription("description-1724546052")
30043010
.setExfiltration(Exfiltration.newBuilder().build())
@@ -3323,6 +3329,7 @@ public void updateFindingTest() throws Exception {
33233329
.addAllConnections(new ArrayList<Connection>())
33243330
.setMuteInitiator("muteInitiator1395645462")
33253331
.addAllProcesses(new ArrayList<Process>())
3332+
.putAllContacts(new HashMap<String, ContactDetails>())
33263333
.addAllCompliances(new ArrayList<Compliance>())
33273334
.setDescription("description-1724546052")
33283335
.setExfiltration(Exfiltration.newBuilder().build())
@@ -3355,6 +3362,7 @@ public void updateFindingTest() throws Exception {
33553362
.addAllConnections(new ArrayList<Connection>())
33563363
.setMuteInitiator("muteInitiator1395645462")
33573364
.addAllProcesses(new ArrayList<Process>())
3365+
.putAllContacts(new HashMap<String, ContactDetails>())
33583366
.addAllCompliances(new ArrayList<Compliance>())
33593367
.setDescription("description-1724546052")
33603368
.setExfiltration(Exfiltration.newBuilder().build())
@@ -3412,6 +3420,7 @@ public void updateFindingExceptionTest() throws Exception {
34123420
.addAllConnections(new ArrayList<Connection>())
34133421
.setMuteInitiator("muteInitiator1395645462")
34143422
.addAllProcesses(new ArrayList<Process>())
3423+
.putAllContacts(new HashMap<String, ContactDetails>())
34153424
.addAllCompliances(new ArrayList<Compliance>())
34163425
.setDescription("description-1724546052")
34173426
.setExfiltration(Exfiltration.newBuilder().build())

‎google-cloud-securitycenter/src/test/java/com/google/cloud/securitycenter/v1/SecurityCenterClientTest.java‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -305,6 +305,7 @@ public void createFindingTest() throws Exception {
305305
.addAllConnections(new ArrayList<Connection>())
306306
.setMuteInitiator("muteInitiator1395645462")
307307
.addAllProcesses(new ArrayList<Process>())
308+
.putAllContacts(new HashMap<String, ContactDetails>())
308309
.addAllCompliances(new ArrayList<Compliance>())
309310
.setDescription("description-1724546052")
310311
.setExfiltration(Exfiltration.newBuilder().build())
@@ -375,6 +376,7 @@ public void createFindingTest2() throws Exception {
375376
.addAllConnections(new ArrayList<Connection>())
376377
.setMuteInitiator("muteInitiator1395645462")
377378
.addAllProcesses(new ArrayList<Process>())
379+
.putAllContacts(new HashMap<String, ContactDetails>())
378380
.addAllCompliances(new ArrayList<Compliance>())
379381
.setDescription("description-1724546052")
380382
.setExfiltration(Exfiltration.newBuilder().build())
@@ -2546,6 +2548,7 @@ public void setFindingStateTest() throws Exception {
25462548
.addAllConnections(new ArrayList<Connection>())
25472549
.setMuteInitiator("muteInitiator1395645462")
25482550
.addAllProcesses(new ArrayList<Process>())
2551+
.putAllContacts(new HashMap<String, ContactDetails>())
25492552
.addAllCompliances(new ArrayList<Compliance>())
25502553
.setDescription("description-1724546052")
25512554
.setExfiltration(Exfiltration.newBuilder().build())
@@ -2618,6 +2621,7 @@ public void setFindingStateTest2() throws Exception {
26182621
.addAllConnections(new ArrayList<Connection>())
26192622
.setMuteInitiator("muteInitiator1395645462")
26202623
.addAllProcesses(new ArrayList<Process>())
2624+
.putAllContacts(new HashMap<String, ContactDetails>())
26212625
.addAllCompliances(new ArrayList<Compliance>())
26222626
.setDescription("description-1724546052")
26232627
.setExfiltration(Exfiltration.newBuilder().build())
@@ -2688,6 +2692,7 @@ public void setMuteTest() throws Exception {
26882692
.addAllConnections(new ArrayList<Connection>())
26892693
.setMuteInitiator("muteInitiator1395645462")
26902694
.addAllProcesses(new ArrayList<Process>())
2695+
.putAllContacts(new HashMap<String, ContactDetails>())
26912696
.addAllCompliances(new ArrayList<Compliance>())
26922697
.setDescription("description-1724546052")
26932698
.setExfiltration(Exfiltration.newBuilder().build())
@@ -2757,6 +2762,7 @@ public void setMuteTest2() throws Exception {
27572762
.addAllConnections(new ArrayList<Connection>())
27582763
.setMuteInitiator("muteInitiator1395645462")
27592764
.addAllProcesses(new ArrayList<Process>())
2765+
.putAllContacts(new HashMap<String, ContactDetails>())
27602766
.addAllCompliances(new ArrayList<Compliance>())
27612767
.setDescription("description-1724546052")
27622768
.setExfiltration(Exfiltration.newBuilder().build())
@@ -3036,6 +3042,7 @@ public void updateFindingTest() throws Exception {
30363042
.addAllConnections(new ArrayList<Connection>())
30373043
.setMuteInitiator("muteInitiator1395645462")
30383044
.addAllProcesses(new ArrayList<Process>())
3045+
.putAllContacts(new HashMap<String, ContactDetails>())
30393046
.addAllCompliances(new ArrayList<Compliance>())
30403047
.setDescription("description-1724546052")
30413048
.setExfiltration(Exfiltration.newBuilder().build())

‎owlbot.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,4 +64,7 @@
6464
s.move(library)
6565

6666
s.remove_staging_dirs()
67-
java.common_templates()
67+
68+
java.common_templates(excludes=[
69+
'.kokoro/presubmit/samples.cfg'
70+
])

0 commit comments

Comments
 (0)