This repository was archived by the owner on Sep 16, 2023. It is now read-only.
feat(v1p1beta1)!: add resource to NotificationMessage, remove having from list requests #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…urce-related fields associated to the Finding notification. docs: Adjusted wording from Cloud SCC to Security Command Center, and updated filtering docs for List APIs. PiperOrigin-RevId: 315715539 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Jun 10 10:20:15 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 3e7056405a83fcbdca86c829d32264b8102fc893 Source-Link: googleapis/googleapis@3e70564
…s resource-related fields associated to the Finding notification. feat!: Removed 'having' as a field for the Group and List APIs for both Assets and Findings. docs: Adjusted wording from Cloud SCC to Security Command Center, and updated filtering docs for List APIs. BREAKING CHANGE: Removed 'having' as a field in the List and Group Finding and Asset requests. PiperOrigin-RevId: 315725809 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Jun 10 11:04:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 027e9775e9d3a6f3eb197fb428727b7f17276e7b Source-Link: googleapis/googleapis@027e977
googlebot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #161 +/- ## ============================================ + Coverage 77.83% 78.65% +0.81% + Complexity 455 396 -59 ============================================ Files 18 18 Lines 3962 3719 -243 Branches 61 61 ============================================ - Hits 3084 2925 -159 + Misses 809 770 -39 + Partials 69 24 -45
Continue to review full report at Codecov.
|
chingor13 changed the title resource to NotificationMessage, remove having from list requests 
chingor13 approved these changes Jun 11, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 11, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.122.0](https://www.github.com/googleapis/java-securitycenter/compare/v0.121.0...v0.122.0) (2020-06-11) ### ⚠ BREAKING CHANGES * **v1p1beta1:** Removed 'having' as a field in the List and Group Finding and Asset requests. * remove legacy resource name (#125) ### Features * remove legacy resource name ([#125](https://www.github.com/googleapis/java-securitycenter/issues/125)) ([d5f88f6](https://www.github.com/googleapis/java-securitycenter/commit/d5f88f6c8c0b182170c405ccaa8f6159fecb4a86)) * **v1p1beta1:** add `resource` to NotificationMessage, remove `having` from list requests ([#161](https://www.github.com/googleapis/java-securitycenter/issues/161)) ([e9c6709](https://www.github.com/googleapis/java-securitycenter/commit/e9c670944e25e6cf24394bdd8dbee7a94ae40846)) ### Dependencies * update dependency com.google.api:api-common to v1.9.1 ([#146](https://www.github.com/googleapis/java-securitycenter/issues/146)) ([ffba078](https://www.github.com/googleapis/java-securitycenter/commit/ffba078dd1da6ad9f78e5c4425f212892eac081f)) * update dependency com.google.api:api-common to v1.9.2 ([#153](https://www.github.com/googleapis/java-securitycenter/issues/153)) ([cfb9e30](https://www.github.com/googleapis/java-securitycenter/commit/cfb9e30815ae07d472e327f30f8a069961a2a813)) * update dependency com.google.api.grpc:proto-google-common-protos to v1.18.0 ([#135](https://www.github.com/googleapis/java-securitycenter/issues/135)) ([760ebf4](https://www.github.com/googleapis/java-securitycenter/commit/760ebf4cf4bd26b10451113bd7141f8303cf238f)) * update dependency com.google.guava:guava-bom to v29 ([#109](https://www.github.com/googleapis/java-securitycenter/issues/109)) ([00a1471](https://www.github.com/googleapis/java-securitycenter/commit/00a1471f0b32e08b9a0bd6fd9c3ff86a510c8d97)) * update dependency com.google.protobuf:protobuf-java to v3.12.0 ([#139](https://www.github.com/googleapis/java-securitycenter/issues/139)) ([213bb0e](https://www.github.com/googleapis/java-securitycenter/commit/213bb0e685eaf36b7ad730425a89e37098dc3f63)) * update dependency com.google.protobuf:protobuf-java to v3.12.2 ([#144](https://www.github.com/googleapis/java-securitycenter/issues/144)) ([455344f](https://www.github.com/googleapis/java-securitycenter/commit/455344f8ac059d845cf481e59007d43e8b06bfa3)) * update dependency io.grpc:grpc-bom to v1.29.0 ([#124](https://www.github.com/googleapis/java-securitycenter/issues/124)) ([24fee0e](https://www.github.com/googleapis/java-securitycenter/commit/24fee0eef8d80ba3eb6999a315a18cbb458bdf53)) * update dependency io.grpc:grpc-bom to v1.30.0 ([#157](https://www.github.com/googleapis/java-securitycenter/issues/157)) ([b97deb9](https://www.github.com/googleapis/java-securitycenter/commit/b97deb90aad2cf0e71480aa91dbe760cd1c5cf70)) * update dependency org.threeten:threetenbp to v1.4.4 ([#129](https://www.github.com/googleapis/java-securitycenter/issues/129)) ([5d62223](https://www.github.com/googleapis/java-securitycenter/commit/5d62223fc6c56a04aee99a8239914c650b4e3c9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/a9613835-4ca9-4e24-a145-9a27c369c58d/targets
PiperOrigin-RevId: 315725809
Source-Link: googleapis/googleapis@027e977
PiperOrigin-RevId: 315715539
Source-Link: googleapis/googleapis@3e70564