fix: Add native image feature to register protobuf reflection in tests #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
chanseokoh approved these changes Nov 3, 2021
chanseokoh left a comment
chanseokoh left a comment There was a problem hiding this comment.
I guess this repo hasn't yet applied the fix to enable the Java 17 test? Ignoring the Java 17 failure, LGTM.
Contributor Author
Ah, I see. Thank you for clarifying this. Merging. |
This was referenced Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes native image test failures such as in googleapis/java-accesscontextmanager#270 where tests use reflection on protobuf classes.