Skip to content

Conversation

@duwenxin99
Copy link
Contributor

Allow user to override default IAM credentials

@duwenxin99 duwenxin99 requested review from a team as code owners July 17, 2024 14:23
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API. label Jul 17, 2024
@duwenxin99 duwenxin99 requested a review from averikitsch July 17, 2024 14:33
@jackwotherspoon
Copy link
Contributor

@duwenxin99 should we add an integration test for this?

Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@duwenxin99 duwenxin99 requested a review from averikitsch July 22, 2024 15:50
@duwenxin99 duwenxin99 merged commit 2de3cba into main Jul 23, 2024
@duwenxin99 duwenxin99 deleted the iam branch July 23, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql-postgres Issues related to the googleapis/langchain-google-cloud-sql-pg-python API.

4 participants