feat: graph_name validation on graph store construction (#162)

* chore: adding graph_name validation on graph store construction * test: add tests for invalid graph name * chore: format fix --------- Co-authored-by: rahul2393 <irahul@google.com>

Author: RedHeadphone

src/langchain_google_spanner/graph_store.py

@@ -132,6 +132,10 @@ def client_with_user_agent(
 class GraphDocumentUtility:
  """Utilities to process graph documents."""
 
+ @staticmethod
+ def is_valid_identifier(s: str) -> bool:
+ return re.match(r"^[a-z][a-z0-9_]{0,127}$", s, re.IGNORECASE) is not None
+
  @staticmethod
  def to_identifier(s: str) -> str:
  return "`" + s + "`"
@@ -780,7 +784,15 @@ def __init__(
  properties as static;
  static_edge_properties: in flexible schema, treat these edge
  properties as static.
+
+ Raises:
+ ValueError: An error occured initializing graph schema.
  """
+ if not GraphDocumentUtility.is_valid_identifier(graph_name):
+ raise ValueError(
+ "Graph name `{}` is not a valid identifier".format(graph_name)
+ )
+
  self.graph_name: str = graph_name
  self.nodes: CaseInsensitiveDict[ElementSchema] = CaseInsensitiveDict({})
  self.edges: CaseInsensitiveDict[ElementSchema] = CaseInsensitiveDict({})

tests/integration/test_spanner_graph_store.py

@@ -400,3 +400,36 @@ def test_spanner_graph_avoid_unnecessary_overwrite(self, use_flexible_schema):
  print("Clean up graph with name `{}`".format(graph_name))
  graph.cleanup()
  print("Actual results:", results)
+
+ @pytest.mark.parametrize(
+ "graph_name, raises_exception",
+ [
+ ("test_graph", False),
+ ("123test_graph", True),
+ ("test_graph2", False),
+ ("test-graph", True),
+ ],
+ )
+ def test_spanner_graph_invalid_graph_name(self, graph_name, raises_exception):
+ suffix = random_string(num_char=5, exclude_whitespaces=True)
+ graph_name += suffix
+ if raises_exception:
+ with pytest.raises(Exception) as excinfo:
+ SpannerGraphStore(
+ instance_id,
+ google_database,
+ graph_name,
+ client=Client(project=project_id),
+ static_node_properties=["a", "b"],
+ static_edge_properties=["a", "b"],
+ )
+ assert "not a valid identifier" in str(excinfo.value)
+ else:
+ SpannerGraphStore(
+ instance_id,
+ google_database,
+ graph_name,
+ client=Client(project=project_id),
+ static_node_properties=["a", "b"],
+ static_edge_properties=["a", "b"],
+ )