test: Vector Store Implementation Integration Tests (#16)

* test: Adding integration tests for static utility to create vector embeddings table. * test: Adding add,search,delete integration tests for VectorStore. * test: lint * test: lint * style: lint * style: lint * Empty-Commit to trigger tests * test: addressing review comments. * test: test fix * adding bs4 in test dependencies --------- Co-authored-by: Averi Kitsch <akitsch@google.com>

Author: gauravpurohit06

pyproject.toml

@@ -22,6 +22,7 @@ Changelog = "https://github.com/googleapis/langchain-google-spanner-python/blob/
 [project.optional-dependencies]
 test = [
  "black[jupyter]==23.12.0",
+ "bs4==0.0.2",
  "isort==5.13.2",
  "mypy==1.7.1",
  "pytest==7.4.4",

src/langchain_google_spanner/__init__.py

@@ -13,6 +13,7 @@
 # limitations under the License.
 
 from langchain_google_spanner.vector_store import (
+ DistanceStrategy,
  QueryParameters,
  SecondaryIndex,
  SpannerVectorStore,
@@ -27,4 +28,5 @@
  "TableColumn",
  "SecondaryIndex",
  "QueryParameters",
+ "DistanceStrategy",
 ]

src/langchain_google_spanner/vector_store.py

@@ -672,12 +672,12 @@ def add_texts(
  if number_of_records == 0:
  return []
 
- if ids is not None:
+ if ids is not None and len(ids) != number_of_records:
  raise ValueError(
  f"size of list of IDs should be equals to number of documents. Expected: {number_of_records} but found {len(ids)}"
  )
 
- if metadatas is not None:
+ if metadatas is not None and len(metadatas) != number_of_records:
  raise ValueError(
  f"size of list of metadatas should be equals to number of documents. Expected: {number_of_records} but found {len(metadatas)}"
  )
@@ -785,8 +785,10 @@ def delete(
 
  values.append(value)
 
+ delete_row_count: int = 0
+
  def delete_records(transaction):
- # ToDo: Debug why not working
+ nonlocal delete_row_count
  base_delete_statement = "DELETE FROM {} WHERE ".format(self._table_name)
 
  (
@@ -798,7 +800,6 @@ def delete_records(transaction):
  sql_delete = base_delete_statement + where_clause
 
  # Iterate over the list of lists of values
- delete_row_count = 0
  for value_tuple in values:
  # Construct the params dictionary
  values_tuple_param = (
@@ -817,7 +818,9 @@ def delete_records(transaction):
 
  self._database.run_in_transaction(delete_records)
 
- return True
+ if delete_row_count > 0:
+ return True
+ return None
 
  def similarity_search_with_score_by_vector(
  self,